mirror of
https://github.com/qemu/qemu.git
synced 2025-07-28 04:52:49 +00:00
3e80f6902c
This is the transformation explained in the commit before previous.
Takes care of just one pattern that needs conversion. More to come in
this series.
Coccinelle script:
@ depends on !(file in "hw/arm/highbank.c")@
expression bus, type_name, dev, expr;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr;
identifier DOWN;
@@
- dev = DOWN(qdev_create(bus, type_name));
+ dev = DOWN(qdev_new(type_name));
... when != dev = expr
- qdev_init_nofail(DEVICE(dev));
+ qdev_realize_and_unref(DEVICE(dev), bus, &error_fatal);
@@
expression bus, type_name, expr;
identifier dev;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- qdev_init_nofail(dev);
+ qdev_realize_and_unref(dev, bus, &error_fatal);
@@
expression bus, type_name, dev, expr, errp;
symbol true;
@@
- dev = qdev_create(bus, type_name);
+ dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
@@
expression bus, type_name, expr, errp;
identifier dev;
symbol true;
@@
- DeviceState *dev = qdev_create(bus, type_name);
+ DeviceState *dev = qdev_new(type_name);
... when != dev = expr
- object_property_set_bool(OBJECT(dev), true, "realized", errp);
+ qdev_realize_and_unref(dev, bus, errp);
The first rule exempts hw/arm/highbank.c, because it matches along two
control flow paths there, with different @type_name. Covered by the
next commit's manual conversions.
Missing #include "qapi/error.h" added manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-10-armbru@redhat.com>
[Conflicts in hw/misc/empty_slot.c and hw/sparc/leon3.c resolved]
54 lines
1.5 KiB
C
54 lines
1.5 KiB
C
/*
|
|
* "Unimplemented" device
|
|
*
|
|
* Copyright Linaro Limited, 2017
|
|
* Written by Peter Maydell
|
|
*/
|
|
|
|
#ifndef HW_MISC_UNIMP_H
|
|
#define HW_MISC_UNIMP_H
|
|
|
|
#include "hw/qdev-properties.h"
|
|
#include "hw/sysbus.h"
|
|
#include "qapi/error.h"
|
|
|
|
#define TYPE_UNIMPLEMENTED_DEVICE "unimplemented-device"
|
|
|
|
#define UNIMPLEMENTED_DEVICE(obj) \
|
|
OBJECT_CHECK(UnimplementedDeviceState, (obj), TYPE_UNIMPLEMENTED_DEVICE)
|
|
|
|
typedef struct {
|
|
SysBusDevice parent_obj;
|
|
MemoryRegion iomem;
|
|
char *name;
|
|
uint64_t size;
|
|
} UnimplementedDeviceState;
|
|
|
|
/**
|
|
* create_unimplemented_device: create and map a dummy device
|
|
* @name: name of the device for debug logging
|
|
* @base: base address of the device's MMIO region
|
|
* @size: size of the device's MMIO region
|
|
*
|
|
* This utility function creates and maps an instance of unimplemented-device,
|
|
* which is a dummy device which simply logs all guest accesses to
|
|
* it via the qemu_log LOG_UNIMP debug log.
|
|
* The device is mapped at priority -1000, which means that you can
|
|
* use it to cover a large region and then map other devices on top of it
|
|
* if necessary.
|
|
*/
|
|
static inline void create_unimplemented_device(const char *name,
|
|
hwaddr base,
|
|
hwaddr size)
|
|
{
|
|
DeviceState *dev = qdev_new(TYPE_UNIMPLEMENTED_DEVICE);
|
|
|
|
qdev_prop_set_string(dev, "name", name);
|
|
qdev_prop_set_uint64(dev, "size", size);
|
|
qdev_realize_and_unref(dev, NULL, &error_fatal);
|
|
|
|
sysbus_mmio_map_overlap(SYS_BUS_DEVICE(dev), 0, base, -1000);
|
|
}
|
|
|
|
#endif
|