mirror of
https://github.com/qemu/qemu.git
synced 2025-10-31 04:06:46 +00:00
ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
63 lines
1.4 KiB
C
63 lines
1.4 KiB
C
/*
|
|
* Virtio GPU Device
|
|
*
|
|
* Copyright Red Hat, Inc. 2013-2014
|
|
*
|
|
* Authors:
|
|
* Dave Airlie <airlied@redhat.com>
|
|
* Gerd Hoffmann <kraxel@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#ifndef HW_VIRTIO_GPU_BSWAP_H
|
|
#define HW_VIRTIO_GPU_BSWAP_H
|
|
|
|
#include "qemu/bswap.h"
|
|
#include "standard-headers/linux/virtio_gpu.h"
|
|
|
|
static inline void
|
|
virtio_gpu_ctrl_hdr_bswap(struct virtio_gpu_ctrl_hdr *hdr)
|
|
{
|
|
le32_to_cpus(&hdr->type);
|
|
le32_to_cpus(&hdr->flags);
|
|
le64_to_cpus(&hdr->fence_id);
|
|
le32_to_cpus(&hdr->ctx_id);
|
|
le32_to_cpus(&hdr->padding);
|
|
}
|
|
|
|
static inline void
|
|
virtio_gpu_bswap_32(void *ptr, size_t size)
|
|
{
|
|
#ifdef HOST_WORDS_BIGENDIAN
|
|
|
|
size_t i;
|
|
struct virtio_gpu_ctrl_hdr *hdr = (struct virtio_gpu_ctrl_hdr *) ptr;
|
|
|
|
virtio_gpu_ctrl_hdr_bswap(hdr);
|
|
|
|
i = sizeof(struct virtio_gpu_ctrl_hdr);
|
|
while (i < size) {
|
|
le32_to_cpus((uint32_t *)(ptr + i));
|
|
i = i + sizeof(uint32_t);
|
|
}
|
|
|
|
#endif
|
|
}
|
|
|
|
static inline void
|
|
virtio_gpu_t2d_bswap(struct virtio_gpu_transfer_to_host_2d *t2d)
|
|
{
|
|
virtio_gpu_ctrl_hdr_bswap(&t2d->hdr);
|
|
le32_to_cpus(&t2d->r.x);
|
|
le32_to_cpus(&t2d->r.y);
|
|
le32_to_cpus(&t2d->r.width);
|
|
le32_to_cpus(&t2d->r.height);
|
|
le64_to_cpus(&t2d->offset);
|
|
le32_to_cpus(&t2d->resource_id);
|
|
le32_to_cpus(&t2d->padding);
|
|
}
|
|
|
|
#endif
|