mirror of
https://github.com/qemu/qemu.git
synced 2025-10-31 12:07:31 +00:00
ae4a2bd759
s390_flic_init() is a helper to create and realize either "s390-flic-kvm" or "s390-flic-qemu". When qdev_init() fails, it complains to stderr and succeeds. Except it can't actually fail, because the "s390-flic-qemu" is a dummy without a realize method, and "s390-flic-kvm"'s realize can't fail, even when the kernel device is really unavailable. Odd. Replace qdev_init() by qdev_init_nofail() to make "can't fail" locally obvious, and get rid of the unreachable error reporting. Cc: Christian Borntraeger <borntraeger@de.ibm.com> Cc: Cornelia Huck <cornelia.huck@de.ibm.com> Cc: Alexander Graf <agraf@suse.de> Signed-off-by: Markus Armbruster <armbru@redhat.com> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> Message-Id: <1423128889-18260-4-git-send-email-armbru@redhat.com> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
100 lines
2.7 KiB
C
100 lines
2.7 KiB
C
/*
|
|
* QEMU S390x floating interrupt controller (flic)
|
|
*
|
|
* Copyright 2014 IBM Corp.
|
|
* Author(s): Jens Freimann <jfrei@linux.vnet.ibm.com>
|
|
* Cornelia Huck <cornelia.huck@de.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or (at
|
|
* your option) any later version. See the COPYING file in the top-level
|
|
* directory.
|
|
*/
|
|
|
|
#include "qemu/error-report.h"
|
|
#include "hw/sysbus.h"
|
|
#include "migration/qemu-file.h"
|
|
#include "hw/s390x/s390_flic.h"
|
|
#include "trace.h"
|
|
|
|
S390FLICState *s390_get_flic(void)
|
|
{
|
|
S390FLICState *fs;
|
|
|
|
fs = S390_FLIC_COMMON(object_resolve_path(TYPE_KVM_S390_FLIC, NULL));
|
|
if (!fs) {
|
|
fs = S390_FLIC_COMMON(object_resolve_path(TYPE_QEMU_S390_FLIC, NULL));
|
|
}
|
|
return fs;
|
|
}
|
|
|
|
void s390_flic_init(void)
|
|
{
|
|
DeviceState *dev;
|
|
|
|
dev = s390_flic_kvm_create();
|
|
if (!dev) {
|
|
dev = qdev_create(NULL, TYPE_QEMU_S390_FLIC);
|
|
object_property_add_child(qdev_get_machine(), TYPE_QEMU_S390_FLIC,
|
|
OBJECT(dev), NULL);
|
|
}
|
|
qdev_init_nofail(dev);
|
|
}
|
|
|
|
static int qemu_s390_register_io_adapter(S390FLICState *fs, uint32_t id,
|
|
uint8_t isc, bool swap,
|
|
bool is_maskable)
|
|
{
|
|
/* nothing to do */
|
|
return 0;
|
|
}
|
|
|
|
static int qemu_s390_io_adapter_map(S390FLICState *fs, uint32_t id,
|
|
uint64_t map_addr, bool do_map)
|
|
{
|
|
/* nothing to do */
|
|
return 0;
|
|
}
|
|
|
|
static int qemu_s390_add_adapter_routes(S390FLICState *fs,
|
|
AdapterRoutes *routes)
|
|
{
|
|
return -ENOSYS;
|
|
}
|
|
|
|
static void qemu_s390_release_adapter_routes(S390FLICState *fs,
|
|
AdapterRoutes *routes)
|
|
{
|
|
}
|
|
|
|
static void qemu_s390_flic_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
S390FLICStateClass *fsc = S390_FLIC_COMMON_CLASS(oc);
|
|
|
|
fsc->register_io_adapter = qemu_s390_register_io_adapter;
|
|
fsc->io_adapter_map = qemu_s390_io_adapter_map;
|
|
fsc->add_adapter_routes = qemu_s390_add_adapter_routes;
|
|
fsc->release_adapter_routes = qemu_s390_release_adapter_routes;
|
|
}
|
|
|
|
static const TypeInfo qemu_s390_flic_info = {
|
|
.name = TYPE_QEMU_S390_FLIC,
|
|
.parent = TYPE_S390_FLIC_COMMON,
|
|
.instance_size = sizeof(QEMUS390FLICState),
|
|
.class_init = qemu_s390_flic_class_init,
|
|
};
|
|
|
|
static const TypeInfo s390_flic_common_info = {
|
|
.name = TYPE_S390_FLIC_COMMON,
|
|
.parent = TYPE_SYS_BUS_DEVICE,
|
|
.instance_size = sizeof(S390FLICState),
|
|
.class_size = sizeof(S390FLICStateClass),
|
|
};
|
|
|
|
static void qemu_s390_flic_register_types(void)
|
|
{
|
|
type_register_static(&s390_flic_common_info);
|
|
type_register_static(&qemu_s390_flic_info);
|
|
}
|
|
|
|
type_init(qemu_s390_flic_register_types)
|