Peter Maydell 9fd9b7de61 accel/tcg: Consider cluster index in tb_lookup__cpu_state() ... In commit f7b78602fd we added the CPU cluster number to the cflags field of the TB hash; this included adding it to the value kept in tb->cflags, since we pass that field directly into the hash calculation in some places. Unfortunately we forgot to check whether other parts of the code were doing comparisons against tb->cflags that would need to be updated. It turns out that there is exactly one such place: the tb_lookup__cpu_state() function checks whether the TB it has found in the tb_jmp_cache has a tb->cflags matching the cf_mask that is passed in. The tb->cflags has the cluster_index in it but the cf_mask does not. Hoist the "add cluster index to the cf_mask" code up from tb_htable_lookup() to tb_lookup__cpu_state() so it can be considered in the "did this TB match in the jmp cache" condition, as well as when we do the full hash lookup by physical PC, flags, etc. (tb_htable_lookup() is only called from tb_lookup__cpu_state(), so this change doesn't require any further knock-on changes.) Fixes: f7b78602fd ("accel/tcg: Add cluster number to TCG TB hash") Tested-by: Cleber Rosa <crosa@redhat.com> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reported-by: Howard Spoelstra <hsp.cat7@gmail.com> Reported-by: Cleber Rosa <crosa@redhat.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20190205151810.571-1-peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>		2019-02-06 03:39:24 +00:00
..
user
address-spaces.h
cpu_ldst_template.h
cpu_ldst_useronly_template.h
cpu_ldst.h	cputlb: Remove static tlb sizing	2019-01-28 07:04:35 -08:00
cpu-all.h
cpu-common.h
cpu-defs.h	cputlb: Remove static tlb sizing	2019-01-28 07:04:35 -08:00
cputlb.h
exec-all.h	accel/tcg: Add cluster number to TCG TB hash	2019-01-29 11:46:06 +00:00
gdbstub.h
gen-icount.h
helper-gen.h
helper-head.h	tcg: Add TCG_CALL_NO_RETURN	2018-12-26 06:40:24 +11:00
helper-proto.h
helper-tcg.h	tcg: Add TCG_CALL_NO_RETURN	2018-12-26 06:40:24 +11:00
hwaddr.h
ioport.h
log.h
memattrs.h	exec: Add target-specific tlb bits to MemTxAttrs	2019-02-05 16:52:37 +00:00
memory_ldst_cached.inc.h
memory_ldst_phys.inc.h
memory_ldst.inc.h
memory-internal.h
memory.h	memory: add memory_region_flush_rom_device()	2019-01-29 11:46:04 +00:00
poison.h
ram_addr.h
ramlist.h
semihost.h
softmmu-semi.h
target_page.h
tb-context.h
tb-hash.h
tb-lookup.h	accel/tcg: Consider cluster index in tb_lookup__cpu_state()	2019-02-06 03:39:24 +00:00
translator.h