Jessica Clarke 8380b3a453 goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH ... The specification says: 0x00 TIME_LOW R: Get current time, then return low-order 32-bits. 0x04 TIME_HIGH R: Return high 32-bits from previous TIME_LOW read. ... To read the value, the kernel must perform an IO_READ(TIME_LOW), which returns an unsigned 32-bit value, before an IO_READ(TIME_HIGH), which returns a signed 32-bit value, corresponding to the higher half of the full value. However, we were just returning the current time for both. If the guest is unlucky enough to read TIME_LOW and TIME_HIGH either side of an overflow of the lower half, it will see time be in the future, before jumping backwards on the next read, and Linux currently relies on the atomicity guaranteed by the spec so is affected by this. Fix this violation of the spec by caching the correct value for TIME_HIGH whenever TIME_LOW is read, and returning that value for any TIME_HIGH read. Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20200718004934.83174-1-jrtc27@jrtc27.com> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>		2020-07-22 09:39:46 -07:00
..
acpi	acpi: Some build_tpm2() code reshape	2020-06-24 17:18:28 -04:00
adc	include: Make headers more self-contained	2019-08-16 13:31:51 +02:00
arm	hw/arm/virt: Enable MTE via a machine property	2020-07-20 11:35:15 +01:00
audio	qom: Put name parameter before value / visitor parameter	2020-07-10 15:18:08 +02:00
block	virtio,acpi,pci: fixes, cleanups.	2020-06-25 16:52:42 +01:00
char	hw/char: Convert the Ibex UART to use the registerfields API	2020-07-13 17:25:37 -07:00
core	cputlb: ensure we save the IOTLB data in case of reset	2020-07-15 11:52:43 +01:00
cpu	Include hw/qdev-properties.h less	2019-08-16 13:31:53 +02:00
cris	sysbus: Convert to sysbus_realize() etc. with Coccinelle	2020-06-15 22:05:28 +02:00
display	qom/object: Move Object typedef to 'qemu/typedefs.h'	2020-06-10 12:09:36 -04:00
dma	hw/arm/bcm283x: Correct the license text	2020-03-23 17:22:30 +00:00
firmware	machine: Refactor smp-related call chains to pass MachineState	2019-07-05 17:07:36 -03:00
gpio	nrf51: Fix last GPIO CNF address	2020-04-30 11:52:27 +01:00
hyperv	hyperv: vmbus: Remove the 2nd IRQ	2020-06-26 09:39:40 -04:00
i2c	hw/i2c: Document the I2C qdev helpers	2020-07-16 12:30:54 -05:00
i386	* Make checkpatch say 'qemu' instead of 'kernel' (Aleksandar)	2020-07-11 16:52:24 +01:00
ide	hw/ide: Make IDEDMAOps handlers take a const IDEDMA pointer	2020-06-17 14:53:39 +02:00
input	adb: add autopoll_blocked variable to block autopoll	2020-06-26 10:13:51 +01:00
intc	hw/intc: RX62N interrupt controller (ICUa)	2020-06-22 18:37:12 +02:00
ipack	Include hw/qdev-properties.h less	2019-08-16 13:31:53 +02:00
ipmi	ipmi: Add support to customize OEM functions	2019-12-17 10:39:47 +11:00
isa	isa: isa_create(), isa_try_create() are now unused, drop	2020-06-15 22:05:28 +02:00
kvm	Supply missing header guards	2019-06-12 13:20:21 +02:00
lm32	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
m68k	m68k: Add NeXTcube machine	2019-09-07 08:31:51 +02:00
mem	hw/acpi/nvdimm: add a helper to augment SRAT generation	2020-06-09 11:17:59 -04:00
mips	Include hw/irq.h a lot less	2019-08-16 13:31:52 +02:00
misc	hw/misc: avr: Add limited support for power reduction device	2020-07-11 11:02:05 +02:00
net	Add a phy-num property to the i.MX FEC emulator	2020-07-03 16:59:41 +01:00
nubus	hw/m68k: add Nubus support	2019-10-28 19:06:47 +01:00
nvram	hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface	2020-07-03 18:16:01 +02:00
pci	virtio-pci: Proxy for virtio-mem	2020-07-03 07:57:04 -04:00
pci-bridge	Supply missing header guards	2019-06-12 13:20:21 +02:00
pci-host	spapr: Add a new level of NUMA for GPUs	2020-07-20 09:21:39 +10:00
ppc	spapr: Add a new level of NUMA for GPUs	2020-07-20 09:21:39 +10:00
rdma	{hmp, hw/pvrdma}: Expose device internals via monitor interface	2019-03-16 15:52:44 +02:00
riscv	riscv: Add opensbi firmware dynamic support	2020-07-13 17:25:37 -07:00
rtc	goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH	2020-07-22 09:39:46 -07:00
rx	hw/rx: Add RX GDB simulator	2020-06-22 18:37:12 +02:00
s390x	s390x/css: Refactor the css_queue_crw() routine	2020-06-18 12:13:54 +02:00
scsi	qdev: Unrealize must not fail	2020-05-15 07:08:14 +02:00
sd	sd: sdhci: Implement basic vendor specific register support	2020-06-16 10:32:29 +01:00
semihosting	semihosting: add qemu_semihosting_console_inc for SYS_READC	2020-01-09 11:41:29 +00:00
sh4	hw/sh4: Extract timer definitions to 'hw/timer/tmu012.h'	2020-06-22 18:37:12 +02:00
southbridge	hw/ide: Do ide_drive_get() within pci_ide_create_devs()	2020-03-17 12:22:36 -04:00
sparc	Include hw/qdev-properties.h less	2019-08-16 13:31:53 +02:00
ssi	Replace uses of FROM_SSI_SLAVE() macro with QOM casts	2020-07-03 16:59:46 +01:00
timer	hw/timer: avr: Add limited support for 16-bit timer peripheral	2020-07-11 11:02:05 +02:00
tricore	Include hw/irq.h a lot less	2019-08-16 13:31:52 +02:00
unicore32	hw/unicore32: restrict hw addr defines to source file	2017-12-18 17:07:02 +03:00
usb	exec/cpu-common: Move MUSB specific typedefs to 'hw/usb/hcd-musb.h'	2020-06-12 11:20:15 -04:00
vfio	vfio: Convert to ram_block_discard_disable()	2020-07-02 05:54:59 -04:00
virtio	virtio,acpi: features, fixes, cleanups.	2020-07-07 17:37:44 +01:00
watchdog	hw/watchdog: Implement full i.MX watchdog support	2020-05-21 20:00:18 +01:00
xen	accel: Move Xen accelerator code under accel/xen/	2020-06-10 12:09:56 -04:00
xtensa	Include hw/irq.h a lot less	2019-08-16 13:31:52 +02:00
boards.h	numa: Auto-enable NUMA when any memory devices are possible	2020-07-03 07:57:04 -04:00
clock.h	hw/core/clock-vmstate: define a vmstate entry for clock state	2020-04-30 15:35:40 +01:00
elf_ops.h	hw/elf_ops: Do not ignore write failures when loading ELF	2020-06-10 12:10:23 -04:00
fw-path-provider.h	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
hotplug.h	qom: make interface types abstract	2018-12-11 15:45:22 -02:00
hw.h	Include hw/hw.h exactly where needed	2019-08-16 13:31:52 +02:00
ide.h	hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.h	2020-03-17 12:22:36 -04:00
irq.h	Revert "irq: introduce qemu_irq_proxy()"	2019-11-05 23:33:12 +01:00
loader-fit.h	Use #include "..." for our own headers, <...> for others	2018-02-09 05:05:11 +01:00
loader.h	hw/core/loader: Let load_elf() populate a field with CPU-specific flags	2020-01-29 19:28:52 +01:00
nmi.h	hw/nmi: Fix the NMI() macro, based on INTERFACE_CHECK()	2020-02-28 14:57:19 -05:00
or-irq.h	hw/core/or-irq: Increase limit of or-lines to 48	2020-01-23 16:34:15 +00:00
pcmcia.h	Include hw/qdev-properties.h less	2019-08-16 13:31:53 +02:00
platform-bus.h	platform-bus-device: use device plug callback instead of machine_done notifier	2018-05-10 18:10:56 +01:00
ptimer.h	ptimer: Remove old ptimer_init_with_bh() API	2019-11-11 13:44:16 +00:00
qdev-clock.h	qdev-clock: introduce an init array to ease the device construction	2020-04-30 15:35:40 +01:00
qdev-core.h	qdev: Document GPIO related functions	2020-07-20 11:35:17 +01:00
qdev-dma.h	Supply missing header guards	2019-06-12 13:20:21 +02:00
qdev-properties.h	qdev: Move doc comments from qdev.c to qdev-core.h	2020-07-20 11:35:17 +01:00
register.h	hw/core/register: Add register_init_block8 helper.	2020-05-05 13:37:51 -07:00
registerfields.h	hw/registerfields: Prefix local variables with underscore in macros	2020-05-27 11:23:07 -07:00
resettable.h	hw/core: deprecate old reset functions and introduce new ones	2020-01-30 16:02:04 +00:00
stream.h	hw/core: stream: Add an end-of-packet flag	2020-05-14 13:44:35 +02:00
sysbus.h	sysbus: sysbus_init_child_obj() is now unused, drop	2020-06-15 22:06:04 +02:00
usb.h	usb: usb_create() is now unused, drop	2020-06-15 22:05:28 +02:00
vmstate-if.h	vmstate: add qom interface to get id	2020-01-06 18:41:32 +04:00