Alberto Garcia 80f5c01183 qcow2: Forbid discard in qcow2 v2 images with backing files ... A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images the cluster is simply deallocated, exposing any possible stale data from the backing file. Since discard is an advisory operation it's safer to simply forbid it in this scenario. Note that we are adding this check to qcow2_co_pdiscard() and not to qcow2_cluster_discard() or discard_in_l2_slice() because the last two are also used by qcow2_snapshot_create() to discard the clusters used by the VM state. In this case there's no risk of exposing stale data to the guest and we really want that the clusters are always discarded. Signed-off-by: Alberto Garcia <berto@igalia.com> Message-Id: <20200331114345.29993-1-berto@igalia.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Max Reitz <mreitz@redhat.com>		2020-04-07 13:51:09 +02:00
..
acceptance	Acceptance test: add "boot_linux" tests	2020-03-17 18:55:52 -04:00
data	rebuild-expected-aml.sh: remind about the process	2020-02-25 08:23:18 -05:00
decode	decodetree: Allow !function with no input bits	2019-08-19 08:03:41 -07:00
docker	tests/docker: Add libepoxy and libudev packages to the Fedora image	2020-03-27 13:43:20 +00:00
fp	testing: don't nest build for fp-test	2020-01-09 11:41:29 +00:00
guest-debug	tests/guest-debug: add a simple test runner	2020-03-17 17:38:47 +00:00
image-fuzzer	image-fuzzer: Use OSerror.strerror instead of tuple subscript	2019-11-05 16:36:11 +01:00
keys
migration	drop "from __future__ import print_function"	2020-02-07 15:15:16 +01:00
multiboot	tests/multiboot: Fix load address of test kernels	2019-07-30 12:25:43 +02:00
perf/block/qcow2	tests/perf: Test lseek influence on qcow2 block-status	2019-06-04 15:20:41 +02:00
plugin	tests/plugins: make howvec clean-up after itself.	2020-02-25 20:20:23 +00:00
qapi-schema	qapi: New special feature flag "deprecated"	2020-03-17 21:42:47 +01:00
qemu-iotests	qcow2: Forbid discard in qcow2 v2 images with backing files	2020-04-07 13:51:09 +02:00
qtest	qtest: add tulip test case	2020-03-31 21:14:35 +08:00
rocker
tcg	tests/tcg/aarch64: add test-sve-ioctl guest-debug test	2020-03-17 17:38:47 +00:00
uefi-test-tools	edk2 build scripts: work around TianoCore#1607 without forcing Python 2	2019-10-07 15:14:15 +02:00
vm	tests/vm: fix basevm config	2020-03-27 13:43:20 +00:00
vmstate-static-checker-data
.gitignore	tests/tcg/aarch64: add a gdbstub testcase for SVE registers	2020-03-17 17:38:47 +00:00
atomic64-bench.c	tests: use g_usleep instead of rem = sleep(time)	2019-01-14 14:52:30 +00:00
atomic_add-bench.c	tests: use g_usleep instead of rem = sleep(time)	2019-01-14 14:52:30 +00:00
benchmark-crypto-cipher.c	tests: benchmark crypto with fixed data size, not time period	2019-10-28 13:32:21 +01:00
benchmark-crypto-hash.c	tests: benchmark crypto with fixed data size, not time period	2019-10-28 13:32:21 +01:00
benchmark-crypto-hmac.c
check-block-qdict.c
check-block.sh	build: move TARGET_GPROF to config-host.mak	2020-02-12 16:29:27 +01:00
check-qdict.c	tests: Move qdict-test-data.txt to tests/data/qobject/	2019-03-07 22:05:54 +01:00
check-qjson.c	test: Use g_strndup instead of plain strndup	2019-08-21 10:27:13 +02:00
check-qlist.c
check-qlit.c
check-qnull.c
check-qnum.c
check-qobject.c
check-qom-interface.c	qom: make interface types abstract	2018-12-11 15:45:22 -02:00
check-qom-proplist.c	tests/qom-proplist: check class properties iterator	2018-10-05 16:27:09 +04:00
check-qstring.c
crypto-tls-psk-helpers.c
crypto-tls-psk-helpers.h	Supply missing header guards	2019-06-12 13:20:21 +02:00
crypto-tls-x509-helpers.c
crypto-tls-x509-helpers.h	Supply missing header guards	2019-06-12 13:20:21 +02:00
dbus-vmstate-daemon.sh	tests: add dbus-vmstate-test	2020-01-06 18:41:32 +04:00
io-channel-helpers.c
io-channel-helpers.h	Normalize position of header guard	2019-06-12 13:20:20 +02:00
iothread.c	tests/iothread: Always connect iothread GSource to a GMainContext	2020-01-07 14:32:57 +00:00
iothread.h
Makefile.include	Python and tests (mostly acceptance) patches 2020-03-17	2020-03-19 12:33:50 +00:00
pkix_asn1_tab.c
ptimer-test-stubs.c	util/qemu-timer: refactor deadline calculation for external timers	2019-08-20 17:26:21 +02:00
ptimer-test.c	tests/ptimer: Remove unnecessary inclusion of libqtest.h	2020-01-12 11:42:40 +01:00
ptimer-test.h
qht-bench.c	tests: use g_usleep instead of rem = sleep(time)	2019-01-14 14:52:30 +00:00
rcutorture.c	tests/rcutorture: mild documenting refactor of update thread	2020-02-25 17:42:59 +00:00
requirements.txt	Acceptance test: add "boot_linux" tests	2020-03-17 18:55:52 -04:00
socket-helpers.c	tests: specify the address family when checking bind	2019-08-22 17:30:25 +04:00
socket-helpers.h	tests: specify the address family when checking bind	2019-08-22 17:30:25 +04:00
test-aio-multithread.c	tests: Do not use "\n" in g_test_message() strings	2019-03-07 22:16:22 +01:00
test-aio.c	util/async: make bh_aio_poll() O(1)	2020-02-22 08:26:47 +00:00
test-authz-list.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-authz-listfile.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-authz-pam.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-authz-simple.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-base64.c
test-bdrv-drain.c	job: drop job_drain	2019-09-10 08:58:43 +02:00
test-bdrv-graph-mod.c	Include qemu/main-loop.h less	2019-08-16 13:31:52 +02:00
test-bitcnt.c
test-bitmap.c	tests: use g_test_rand_int	2019-12-17 09:05:23 +01:00
test-bitops.c
test-block-backend.c	Include qemu/main-loop.h less	2019-08-16 13:31:52 +02:00
test-block-iothread.c	block: Add @exact parameter to bdrv_co_truncate()	2019-10-28 12:00:07 +01:00
test-blockjob-txn.c	job: drop job_drain	2019-09-10 08:58:43 +02:00
test-blockjob.c	tests-blockjob: Use error_free_or_abort()	2019-12-18 08:36:16 +01:00
test-bufferiszero.c
test-char.c	chardev: Use QEMUChrEvent enum in IOEventHandler typedef	2020-01-08 11:15:35 +01:00
test-clone-visitor.c	tests: Rename UserDefNativeListUnion to UserDefListUnion	2019-03-05 14:43:11 +01:00
test-coroutine.c	tests: Do not use "\n" in g_test_message() strings	2019-03-07 22:16:22 +01:00
test-crypto-afsplit.c
test-crypto-block.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-crypto-cipher.c
test-crypto-hash.c
test-crypto-hmac.c
test-crypto-ivgen.c
test-crypto-pbkdf.c	test: execute g_test_run when tests are skipped	2019-01-11 13:57:25 +01:00
test-crypto-secret.c
test-crypto-tlscredsx509.c	glib: use portable g_setenv()	2019-12-17 09:05:23 +01:00
test-crypto-tlssession.c	glib: use portable g_setenv()	2019-12-17 09:05:23 +01:00
test-crypto-xts.c	crypto: add testing for unaligned buffers with XTS cipher mode	2018-10-24 19:03:37 +01:00
test-cutils.c	cutils: Fix qemu_strtosz() & friends to reject non-finite sizes	2018-12-13 19:10:06 +01:00
test-hbitmap.c	block/dirty-bitmap: improve _next_dirty_area API	2020-03-18 14:03:46 -04:00
test-image-locking.c	Include qemu/main-loop.h less	2019-08-16 13:31:52 +02:00
test-int128.c
test-io-channel-buffer.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-io-channel-command.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-io-channel-file.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-io-channel-socket.c	socket: Add num connections to qio_channel_socket_async()	2019-09-03 23:24:42 +02:00
test-io-channel-tls.c	glib: use portable g_setenv()	2019-12-17 09:05:23 +01:00
test-io-task.c	Include qemu/module.h where needed, drop it from qemu-common.h	2019-06-12 13:18:33 +02:00
test-iov.c
test-keyval.c	test-keyval: Tighten test of trailing crap after size	2019-12-18 12:28:44 +01:00
test-logging.c	test-logging: Fix -Werror=maybe-uninitialized warning	2020-02-04 09:00:57 +01:00
test-mul64.c
test-opts-visitor.c
test-qapi-util.c
test-qdev-global-props.c	qdev: set properties with device_class_set_props()	2020-01-24 20:59:15 +01:00
test-qdist.c
test-qemu-opts.c
test-qga.c	tests: use g_test_rand_int	2019-12-17 09:05:23 +01:00
test-qgraph.c	tests: test-qgraph: fix a memory leak	2019-03-11 16:33:49 +01:00
test-qht-par.c
test-qht.c
test-qmp-cmds.c	qapi: Add feature flags to remaining definitions	2020-03-17 19:58:34 +01:00
test-qmp-event.c	tests/test-qmp-event: Check event is actually emitted	2020-03-17 19:58:34 +01:00
test-qobject-input-visitor.c	tests: Rename UserDefNativeListUnion to UserDefListUnion	2019-03-05 14:43:11 +01:00
test-qobject-output-visitor.c	tests: Clean up initialization of Error *err variables	2019-12-18 08:36:15 +01:00
test-rcu-list.c	tests: Fix a bug with count variables	2020-03-06 10:35:15 +00:00
test-rcu-simpleq.c
test-rcu-slist.c	rcu_queue: add QSLIST functions	2020-02-22 08:26:47 +00:00
test-rcu-tailq.c
test-replication.c	tests/test-replication.c: Add test for for secondary node continuing replication	2020-03-03 18:04:47 +08:00
test-shift128.c
test-string-input-visitor.c	tests: Fix uninitialized byte in test_visitor_in_fuzz	2019-08-20 17:26:19 +02:00
test-string-output-visitor.c	tests: Clean up initialization of Error *err variables	2019-12-18 08:36:15 +01:00
test-thread-pool.c	test-thread-pool: be more reliable	2019-06-03 14:03:00 +02:00
test-throttle.c	test-throttle: Fix uninitialized use of burst_length	2019-08-20 17:26:19 +02:00
test-timed-average.c
test-util-filemonitor.c	tests/test-util-filemonitor: Skip test on non-x86 Travis containers	2019-12-18 20:17:45 +00:00
test-util-sockets.c	hmp: Fail gracefully if chardev is already in use	2020-03-06 17:21:28 +01:00
test-uuid.c
test-visitor-serialization.c
test-vmstate.c	test-vmstate: Fix memleaks in test_load_qlist	2020-02-28 09:25:49 +01:00
test-write-threshold.c
test-x86-cpuid.c	hw/i386: Update structures to save the number of nodes per package	2020-03-17 19:48:10 -04:00
test-xbzrle.c
vhost-user-bridge.c	core: replace getpagesize() with qemu_real_host_page_size	2019-10-26 15:38:06 +02:00