mirror of
				https://github.com/qemu/qemu.git
				synced 2025-10-26 03:33:28 +00:00 
			
		
		
		
	 668f62ec62
			
		
	
	
		668f62ec62
		
	
	
	
	
		
			
			When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away.  Convert
    if (!foo(..., &err)) {
        ...
        error_propagate(errp, err);
        ...
        return ...
    }
to
    if (!foo(..., errp)) {
        ...
        ...
        return ...
    }
where nothing else needs @err.  Coccinelle script:
    @rule1 forall@
    identifier fun, err, errp, lbl;
    expression list args, args2;
    binary operator op;
    constant c1, c2;
    symbol false;
    @@
         if (
    (
    -        fun(args, &err, args2)
    +        fun(args, errp, args2)
    |
    -        !fun(args, &err, args2)
    +        !fun(args, errp, args2)
    |
    -        fun(args, &err, args2) op c1
    +        fun(args, errp, args2) op c1
    )
            )
         {
             ... when != err
                 when != lbl:
                 when strict
    -        error_propagate(errp, err);
             ... when != err
    (
             return;
    |
             return c2;
    |
             return false;
    )
         }
    @rule2 forall@
    identifier fun, err, errp, lbl;
    expression list args, args2;
    expression var;
    binary operator op;
    constant c1, c2;
    symbol false;
    @@
    -    var = fun(args, &err, args2);
    +    var = fun(args, errp, args2);
         ... when != err
         if (
    (
             var
    |
             !var
    |
             var op c1
    )
            )
         {
             ... when != err
                 when != lbl:
                 when strict
    -        error_propagate(errp, err);
             ... when != err
    (
             return;
    |
             return c2;
    |
             return false;
    |
             return var;
    )
         }
    @depends on rule1 || rule2@
    identifier err;
    @@
    -    Error *err = NULL;
         ... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
         if (fun(args, &err)) {
             goto out
         }
         ...
     out:
         error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly.  I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err".  For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there.  Converted manually.
Line breaks tidied up manually.  One nested declaration of @local_err
deleted manually.  Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
		
	
			
		
			
				
	
	
		
			181 lines
		
	
	
		
			6.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			181 lines
		
	
	
		
			6.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Cortex-A15MPCore internal peripheral emulation.
 | |
|  *
 | |
|  * Copyright (c) 2012 Linaro Limited.
 | |
|  * Written by Peter Maydell.
 | |
|  *
 | |
|  * This program is free software; you can redistribute it and/or modify
 | |
|  * it under the terms of the GNU General Public License as published by
 | |
|  * the Free Software Foundation; either version 2 of the License, or
 | |
|  * (at your option) any later version.
 | |
|  *
 | |
|  * This program is distributed in the hope that it will be useful,
 | |
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
|  * GNU General Public License for more details.
 | |
|  *
 | |
|  * You should have received a copy of the GNU General Public License along
 | |
|  * with this program; if not, see <http://www.gnu.org/licenses/>.
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| #include "qapi/error.h"
 | |
| #include "qemu/module.h"
 | |
| #include "hw/cpu/a15mpcore.h"
 | |
| #include "hw/irq.h"
 | |
| #include "hw/qdev-properties.h"
 | |
| #include "sysemu/kvm.h"
 | |
| #include "kvm_arm.h"
 | |
| 
 | |
| static void a15mp_priv_set_irq(void *opaque, int irq, int level)
 | |
| {
 | |
|     A15MPPrivState *s = (A15MPPrivState *)opaque;
 | |
| 
 | |
|     qemu_set_irq(qdev_get_gpio_in(DEVICE(&s->gic), irq), level);
 | |
| }
 | |
| 
 | |
| static void a15mp_priv_initfn(Object *obj)
 | |
| {
 | |
|     SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
 | |
|     A15MPPrivState *s = A15MPCORE_PRIV(obj);
 | |
| 
 | |
|     memory_region_init(&s->container, obj, "a15mp-priv-container", 0x8000);
 | |
|     sysbus_init_mmio(sbd, &s->container);
 | |
| 
 | |
|     object_initialize_child(obj, "gic", &s->gic, gic_class_name());
 | |
|     qdev_prop_set_uint32(DEVICE(&s->gic), "revision", 2);
 | |
| }
 | |
| 
 | |
| static void a15mp_priv_realize(DeviceState *dev, Error **errp)
 | |
| {
 | |
|     SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
 | |
|     A15MPPrivState *s = A15MPCORE_PRIV(dev);
 | |
|     DeviceState *gicdev;
 | |
|     SysBusDevice *busdev;
 | |
|     int i;
 | |
|     bool has_el3;
 | |
|     bool has_el2 = false;
 | |
|     Object *cpuobj;
 | |
| 
 | |
|     gicdev = DEVICE(&s->gic);
 | |
|     qdev_prop_set_uint32(gicdev, "num-cpu", s->num_cpu);
 | |
|     qdev_prop_set_uint32(gicdev, "num-irq", s->num_irq);
 | |
| 
 | |
|     if (!kvm_irqchip_in_kernel()) {
 | |
|         /* Make the GIC's TZ support match the CPUs. We assume that
 | |
|          * either all the CPUs have TZ, or none do.
 | |
|          */
 | |
|         cpuobj = OBJECT(qemu_get_cpu(0));
 | |
|         has_el3 = object_property_find(cpuobj, "has_el3", NULL) &&
 | |
|             object_property_get_bool(cpuobj, "has_el3", &error_abort);
 | |
|         qdev_prop_set_bit(gicdev, "has-security-extensions", has_el3);
 | |
|         /* Similarly for virtualization support */
 | |
|         has_el2 = object_property_find(cpuobj, "has_el2", NULL) &&
 | |
|             object_property_get_bool(cpuobj, "has_el2", &error_abort);
 | |
|         qdev_prop_set_bit(gicdev, "has-virtualization-extensions", has_el2);
 | |
|     }
 | |
| 
 | |
|     if (!sysbus_realize(SYS_BUS_DEVICE(&s->gic), errp)) {
 | |
|         return;
 | |
|     }
 | |
|     busdev = SYS_BUS_DEVICE(&s->gic);
 | |
| 
 | |
|     /* Pass through outbound IRQ lines from the GIC */
 | |
|     sysbus_pass_irq(sbd, busdev);
 | |
| 
 | |
|     /* Pass through inbound GPIO lines to the GIC */
 | |
|     qdev_init_gpio_in(dev, a15mp_priv_set_irq, s->num_irq - 32);
 | |
| 
 | |
|     /* Wire the outputs from each CPU's generic timer to the
 | |
|      * appropriate GIC PPI inputs
 | |
|      */
 | |
|     for (i = 0; i < s->num_cpu; i++) {
 | |
|         DeviceState *cpudev = DEVICE(qemu_get_cpu(i));
 | |
|         int ppibase = s->num_irq - 32 + i * 32;
 | |
|         int irq;
 | |
|         /* Mapping from the output timer irq lines from the CPU to the
 | |
|          * GIC PPI inputs used on the A15:
 | |
|          */
 | |
|         const int timer_irq[] = {
 | |
|             [GTIMER_PHYS] = 30,
 | |
|             [GTIMER_VIRT] = 27,
 | |
|             [GTIMER_HYP]  = 26,
 | |
|             [GTIMER_SEC]  = 29,
 | |
|         };
 | |
|         for (irq = 0; irq < ARRAY_SIZE(timer_irq); irq++) {
 | |
|             qdev_connect_gpio_out(cpudev, irq,
 | |
|                                   qdev_get_gpio_in(gicdev,
 | |
|                                                    ppibase + timer_irq[irq]));
 | |
|         }
 | |
|         if (has_el2) {
 | |
|             /* Connect the GIC maintenance interrupt to PPI ID 25 */
 | |
|             sysbus_connect_irq(SYS_BUS_DEVICE(gicdev), i + 4 * s->num_cpu,
 | |
|                                qdev_get_gpio_in(gicdev, ppibase + 25));
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     /* Memory map (addresses are offsets from PERIPHBASE):
 | |
|      *  0x0000-0x0fff -- reserved
 | |
|      *  0x1000-0x1fff -- GIC Distributor
 | |
|      *  0x2000-0x3fff -- GIC CPU interface
 | |
|      *  0x4000-0x4fff -- GIC virtual interface control for this CPU
 | |
|      *  0x5000-0x51ff -- GIC virtual interface control for CPU 0
 | |
|      *  0x5200-0x53ff -- GIC virtual interface control for CPU 1
 | |
|      *  0x5400-0x55ff -- GIC virtual interface control for CPU 2
 | |
|      *  0x5600-0x57ff -- GIC virtual interface control for CPU 3
 | |
|      *  0x6000-0x7fff -- GIC virtual CPU interface
 | |
|      */
 | |
|     memory_region_add_subregion(&s->container, 0x1000,
 | |
|                                 sysbus_mmio_get_region(busdev, 0));
 | |
|     memory_region_add_subregion(&s->container, 0x2000,
 | |
|                                 sysbus_mmio_get_region(busdev, 1));
 | |
|     if (has_el2) {
 | |
|         memory_region_add_subregion(&s->container, 0x4000,
 | |
|                                     sysbus_mmio_get_region(busdev, 2));
 | |
|         memory_region_add_subregion(&s->container, 0x6000,
 | |
|                                     sysbus_mmio_get_region(busdev, 3));
 | |
|         for (i = 0; i < s->num_cpu; i++) {
 | |
|             hwaddr base = 0x5000 + i * 0x200;
 | |
|             MemoryRegion *mr = sysbus_mmio_get_region(busdev,
 | |
|                                                       4 + s->num_cpu + i);
 | |
|             memory_region_add_subregion(&s->container, base, mr);
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| static Property a15mp_priv_properties[] = {
 | |
|     DEFINE_PROP_UINT32("num-cpu", A15MPPrivState, num_cpu, 1),
 | |
|     /* The Cortex-A15MP may have anything from 0 to 224 external interrupt
 | |
|      * IRQ lines (with another 32 internal). We default to 128+32, which
 | |
|      * is the number provided by the Cortex-A15MP test chip in the
 | |
|      * Versatile Express A15 development board.
 | |
|      * Other boards may differ and should set this property appropriately.
 | |
|      */
 | |
|     DEFINE_PROP_UINT32("num-irq", A15MPPrivState, num_irq, 160),
 | |
|     DEFINE_PROP_END_OF_LIST(),
 | |
| };
 | |
| 
 | |
| static void a15mp_priv_class_init(ObjectClass *klass, void *data)
 | |
| {
 | |
|     DeviceClass *dc = DEVICE_CLASS(klass);
 | |
| 
 | |
|     dc->realize = a15mp_priv_realize;
 | |
|     device_class_set_props(dc, a15mp_priv_properties);
 | |
|     /* We currently have no savable state */
 | |
| }
 | |
| 
 | |
| static const TypeInfo a15mp_priv_info = {
 | |
|     .name  = TYPE_A15MPCORE_PRIV,
 | |
|     .parent = TYPE_SYS_BUS_DEVICE,
 | |
|     .instance_size  = sizeof(A15MPPrivState),
 | |
|     .instance_init = a15mp_priv_initfn,
 | |
|     .class_init = a15mp_priv_class_init,
 | |
| };
 | |
| 
 | |
| static void a15mp_register_types(void)
 | |
| {
 | |
|     type_register_static(&a15mp_priv_info);
 | |
| }
 | |
| 
 | |
| type_init(a15mp_register_types)
 |