mirror of
				https://github.com/qemu/qemu.git
				synced 2025-10-31 20:44:16 +00:00 
			
		
		
		
	 0e72078128
			
		
	
	
		0e72078128
		
	
	
	
	
		
			
			With bash 5.1, the output of the following script changes:
  a=("double  space")
  a=${a[@]:0:1}
  echo "$a"
from "double space" to "double  space", i.e. all white space is
preserved as-is.  This is probably what we actually want here (judging
from the "...to accommodate pathnames with spaces" comment), but before
5.1, we would have to quote the ${} slice to get the same behavior.
In any case, without quoting, the reference output of many iotests is
different between bash 5.1 and pre-5.1, which is not very good.  The
output of 5.1 is what we want, so whatever we do to get pre-5.1 to the
same result, it means we have to fix the reference output of basically
all tests that invoke _send_qemu_cmd (except the ones that only use
single spaces in the commands they invoke).
Instead of quoting the ${} slice (cmd="${$@: 1:...}"), we can also just
not use array slicing and replace the whole thing with a simple "cmd=$1;
shift", which works because all callers quote the whole $cmd argument
anyway.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20201217153803.101231-3-mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
		
	
			
		
			
				
	
	
		
			171 lines
		
	
	
		
			5.5 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			171 lines
		
	
	
		
			5.5 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| QA output created by 308
 | |
| === Set up ===
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | |
| wrote 67108864/67108864 bytes at offset 0
 | |
| 64 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| {'execute': 'qmp_capabilities'}
 | |
| {"return": {}}
 | |
| {'execute': 'blockdev-add',
 | |
|       'arguments': {
 | |
|           'driver': 'file',
 | |
|           'node-name': 'node-protocol',
 | |
|           'filename': 'TEST_DIR/t.IMGFMT'
 | |
|       } }
 | |
| {"return": {}}
 | |
| {'execute': 'blockdev-add',
 | |
|       'arguments': {
 | |
|           'driver': 'IMGFMT',
 | |
|           'node-name': 'node-format',
 | |
|           'file': 'node-protocol'
 | |
|       } }
 | |
| {"return": {}}
 | |
| 
 | |
| === Mountpoint not present ===
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-err',
 | |
|               'node-name': 'node-format',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | |
|           } }
 | |
| {"error": {"class": "GenericError", "desc": "Failed to stat 'TEST_DIR/t.IMGFMT.fuse': No such file or directory"}}
 | |
| 
 | |
| === Mountpoint is a directory ===
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-err',
 | |
|               'node-name': 'node-format',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | |
|           } }
 | |
| {"error": {"class": "GenericError", "desc": "'TEST_DIR/t.IMGFMT.fuse' is not a regular file"}}
 | |
| 
 | |
| === Mountpoint is a regular file ===
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-mp',
 | |
|               'node-name': 'node-format',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | |
|           } }
 | |
| {"return": {}}
 | |
| Images are identical.
 | |
| 
 | |
| === Mount over existing file ===
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-img',
 | |
|               'node-name': 'node-format',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT'
 | |
|           } }
 | |
| {"return": {}}
 | |
| Images are identical.
 | |
| 
 | |
| === Double export ===
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-err',
 | |
|               'node-name': 'node-format',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT.fuse'
 | |
|           } }
 | |
| {"error": {"class": "GenericError", "desc": "There already is a FUSE export on 'TEST_DIR/t.IMGFMT.fuse'"}}
 | |
| 
 | |
| === Remove export ===
 | |
| virtual size: 64 MiB (67108864 bytes)
 | |
| {'execute': 'block-export-del',
 | |
|           'arguments': {
 | |
|               'id': 'export-mp'
 | |
|           } }
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | |
| virtual size: 0 B (0 bytes)
 | |
| 
 | |
| === Writable export ===
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-mp',
 | |
|               'node-name': 'node-format',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT.fuse', 'writable': true
 | |
|           } }
 | |
| {"return": {}}
 | |
| write failed: Permission denied
 | |
| wrote 65536/65536 bytes at offset 1048576
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 1048576
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| === Resizing exports ===
 | |
| {'execute': 'block-export-del',
 | |
|           'arguments': {
 | |
|               'id': 'export-mp'
 | |
|           } }
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | |
| {'execute': 'block-export-del',
 | |
|           'arguments': {
 | |
|               'id': 'export-img'
 | |
|           } }
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-img"}}
 | |
| {'execute': 'blockdev-del',
 | |
|       'arguments': {
 | |
|           'node-name': 'node-format'
 | |
|       } }
 | |
| {"return": {}}
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-mp',
 | |
|               'node-name': 'node-protocol',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT.fuse', 'writable': true
 | |
|           } }
 | |
| {"return": {}}
 | |
| 
 | |
| --- Try growing non-growable export ---
 | |
| (OK: Lengths of export and original are the same)
 | |
| dd: error writing 'TEST_DIR/t.IMGFMT.fuse': Input/output error
 | |
| 1+0 records in
 | |
| 0+0 records out
 | |
| 
 | |
| --- Resize export ---
 | |
| (OK: Lengths of export and original are the same)
 | |
| OK: Post-truncate image size is as expected
 | |
| OK: Disk usage grew with fallocate
 | |
| 
 | |
| --- Try growing growable export ---
 | |
| {'execute': 'block-export-del',
 | |
|           'arguments': {
 | |
|               'id': 'export-mp'
 | |
|           } }
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | |
| {'execute': 'block-export-add',
 | |
|           'arguments': {
 | |
|               'type': 'fuse',
 | |
|               'id': 'export-mp',
 | |
|               'node-name': 'node-protocol',
 | |
|               'mountpoint': 'TEST_DIR/t.IMGFMT.fuse', 'writable': true, 'growable': true
 | |
|           } }
 | |
| {"return": {}}
 | |
| 65536+0 records in
 | |
| 65536+0 records out
 | |
| (OK: Lengths of export and original are the same)
 | |
| OK: Post-grow image size is as expected
 | |
| 
 | |
| --- Shrink export ---
 | |
| (OK: Lengths of export and original are the same)
 | |
| OK: Post-truncate image size is as expected
 | |
| 
 | |
| === Tear down ===
 | |
| {'execute': 'quit'}
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_EXPORT_DELETED", "data": {"id": "export-mp"}}
 | |
| 
 | |
| === Compare copy with original ===
 | |
| Images are identical.
 | |
| *** done
 |