mirror of
				https://github.com/qemu/qemu.git
				synced 2025-10-31 04:06:46 +00:00 
			
		
		
		
	 0e72078128
			
		
	
	
		0e72078128
		
	
	
	
	
		
			
			With bash 5.1, the output of the following script changes:
  a=("double  space")
  a=${a[@]:0:1}
  echo "$a"
from "double space" to "double  space", i.e. all white space is
preserved as-is.  This is probably what we actually want here (judging
from the "...to accommodate pathnames with spaces" comment), but before
5.1, we would have to quote the ${} slice to get the same behavior.
In any case, without quoting, the reference output of many iotests is
different between bash 5.1 and pre-5.1, which is not very good.  The
output of 5.1 is what we want, so whatever we do to get pre-5.1 to the
same result, it means we have to fix the reference output of basically
all tests that invoke _send_qemu_cmd (except the ones that only use
single spaces in the commands they invoke).
Instead of quoting the ${} slice (cmd="${$@: 1:...}"), we can also just
not use array slicing and replace the whole thing with a simple "cmd=$1;
shift", which works because all callers quote the whole $cmd argument
anyway.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20201217153803.101231-3-mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
		
	
			
		
			
				
	
	
		
			57 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			57 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| QA output created by 144
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=536870912
 | |
| 
 | |
| === Launching QEMU ===
 | |
| 
 | |
| 
 | |
| === Performing Live Snapshot 1 ===
 | |
| 
 | |
| { 'execute': 'qmp_capabilities' }
 | |
| {"return": {}}
 | |
| { 'execute': 'blockdev-snapshot-sync',
 | |
|                                 'arguments': {
 | |
|                                              'device': 'virtio0',
 | |
|                                              'snapshot-file':'TEST_DIR/tmp.IMGFMT',
 | |
|                                              'format': 'IMGFMT'
 | |
|                                              }
 | |
|                     }
 | |
| Formatting 'TEST_DIR/tmp.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=536870912 backing_file=TEST_DIR/t.qcow2 backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16
 | |
| {"return": {}}
 | |
| 
 | |
| === Performing block-commit on active layer ===
 | |
| 
 | |
| { 'execute': 'block-commit',
 | |
|                                 'arguments': {
 | |
|                                                  'device': 'virtio0'
 | |
|                                               }
 | |
|                     }
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "virtio0"}}
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_JOB_READY", "data": {"device": "virtio0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
 | |
| { 'execute': 'block-job-complete',
 | |
|                                 'arguments': {
 | |
|                                                 'device': 'virtio0'
 | |
|                                               }
 | |
|                    }
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "virtio0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "concluded", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "null", "id": "virtio0"}}
 | |
| 
 | |
| === Performing Live Snapshot 2 ===
 | |
| 
 | |
| { 'execute': 'blockdev-snapshot-sync',
 | |
|                                 'arguments': {
 | |
|                                                 'device': 'virtio0',
 | |
|                                                 'snapshot-file':'TEST_DIR/tmp2.IMGFMT',
 | |
|                                                 'format': 'IMGFMT'
 | |
|                                               }
 | |
|                    }
 | |
| Formatting 'TEST_DIR/tmp2.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=536870912 backing_file=TEST_DIR/t.qcow2 backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16
 | |
| {"return": {}}
 | |
| *** done
 |