mirror of
https://github.com/qemu/qemu.git
synced 2025-10-31 20:44:16 +00:00
739fc38778
The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per "file description", this non-blocking behaviour is then shared with any other process that's using the stdin/stdout of the 'make check' run, including make itself. This can result in make falling over with "make: write error: stdout" because it got an unexpected EINTR trying to write output messages to the terminal. This is particularly noticable if running 'make check' in a loop with while make check; do true; done (It does not affect single make check runs so much because the shell will remove the O_NONBLOCK status before it reads the terminal for interactive input.) Remove the unwanted -nographic argument. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
46 lines
1.1 KiB
C
46 lines
1.1 KiB
C
/*
|
|
* QTest testcase for the Intel Hexadecimal Object File Loader
|
|
*
|
|
* Authors:
|
|
* Su Hang <suhang16@mails.ucas.ac.cn> 2018
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "libqtest.h"
|
|
|
|
/* Load 'test.hex' and verify that the in-memory contents are as expected.
|
|
* 'test.hex' is a memory test pattern stored in Hexadecimal Object
|
|
* format. It loads at 0x10000 in RAM and contains values from 0 through
|
|
* 255.
|
|
*/
|
|
static void hex_loader_test(void)
|
|
{
|
|
unsigned int i;
|
|
const unsigned int base_addr = 0x00010000;
|
|
|
|
QTestState *s = qtest_initf(
|
|
"-M vexpress-a9 -device loader,file=tests/data/hex-loader/test.hex");
|
|
|
|
for (i = 0; i < 256; ++i) {
|
|
uint8_t val = qtest_readb(s, base_addr + i);
|
|
g_assert_cmpuint(i, ==, val);
|
|
}
|
|
qtest_quit(s);
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
int ret;
|
|
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
qtest_add_func("/tmp/hex_loader", hex_loader_test);
|
|
ret = g_test_run();
|
|
|
|
return ret;
|
|
}
|