mirror of
				https://github.com/qemu/qemu.git
				synced 2025-10-31 12:07:31 +00:00 
			
		
		
		
	 3caab54d08
			
		
	
	
		3caab54d08
		
	
	
	
	
		
			
			Spotted by ASAN. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Greg Kurz <groug@kaod.org> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
		
			
				
	
	
		
			257 lines
		
	
	
		
			7.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			257 lines
		
	
	
		
			7.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * QTest testcase for VirtIO SCSI
 | |
|  *
 | |
|  * Copyright (c) 2014 SUSE LINUX Products GmbH
 | |
|  * Copyright (c) 2015 Red Hat Inc.
 | |
|  *
 | |
|  * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | |
|  * See the COPYING file in the top-level directory.
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| #include "libqtest.h"
 | |
| #include "block/scsi.h"
 | |
| #include "libqos/libqos-pc.h"
 | |
| #include "libqos/libqos-spapr.h"
 | |
| #include "libqos/virtio.h"
 | |
| #include "libqos/virtio-pci.h"
 | |
| #include "standard-headers/linux/virtio_ids.h"
 | |
| #include "standard-headers/linux/virtio_pci.h"
 | |
| #include "standard-headers/linux/virtio_scsi.h"
 | |
| 
 | |
| #define PCI_SLOT                0x02
 | |
| #define PCI_FN                  0x00
 | |
| #define QVIRTIO_SCSI_TIMEOUT_US (1 * 1000 * 1000)
 | |
| 
 | |
| #define MAX_NUM_QUEUES 64
 | |
| 
 | |
| typedef struct {
 | |
|     QVirtioDevice *dev;
 | |
|     QOSState *qs;
 | |
|     int num_queues;
 | |
|     QVirtQueue *vq[MAX_NUM_QUEUES + 2];
 | |
| } QVirtIOSCSI;
 | |
| 
 | |
| static QOSState *qvirtio_scsi_start(const char *extra_opts)
 | |
| {
 | |
|     const char *arch = qtest_get_arch();
 | |
|     const char *cmd = "-drive id=drv0,if=none,file=/dev/null,format=raw "
 | |
|                       "-device virtio-scsi-pci,id=vs0 "
 | |
|                       "-device scsi-hd,bus=vs0.0,drive=drv0 %s";
 | |
| 
 | |
|     if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
 | |
|         return qtest_pc_boot(cmd, extra_opts ? : "");
 | |
|     }
 | |
|     if (strcmp(arch, "ppc64") == 0) {
 | |
|         return qtest_spapr_boot(cmd, extra_opts ? : "");
 | |
|     }
 | |
| 
 | |
|     g_printerr("virtio-scsi tests are only available on x86 or ppc64\n");
 | |
|     exit(EXIT_FAILURE);
 | |
| }
 | |
| 
 | |
| static void qvirtio_scsi_stop(QOSState *qs)
 | |
| {
 | |
|     qtest_shutdown(qs);
 | |
| }
 | |
| 
 | |
| static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
 | |
| {
 | |
|     int i;
 | |
| 
 | |
|     for (i = 0; i < vs->num_queues + 2; i++) {
 | |
|         qvirtqueue_cleanup(vs->dev->bus, vs->vq[i], vs->qs->alloc);
 | |
|     }
 | |
|     qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev));
 | |
|     qvirtio_pci_device_free((QVirtioPCIDevice *)vs->dev);
 | |
|     qvirtio_scsi_stop(vs->qs);
 | |
|     g_free(vs);
 | |
| }
 | |
| 
 | |
| static uint64_t qvirtio_scsi_alloc(QVirtIOSCSI *vs, size_t alloc_size,
 | |
|                                    const void *data)
 | |
| {
 | |
|     uint64_t addr;
 | |
| 
 | |
|     addr = guest_alloc(vs->qs->alloc, alloc_size);
 | |
|     if (data) {
 | |
|         memwrite(addr, data, alloc_size);
 | |
|     }
 | |
| 
 | |
|     return addr;
 | |
| }
 | |
| 
 | |
| static uint8_t virtio_scsi_do_command(QVirtIOSCSI *vs, const uint8_t *cdb,
 | |
|                                       const uint8_t *data_in,
 | |
|                                       size_t data_in_len,
 | |
|                                       uint8_t *data_out, size_t data_out_len,
 | |
|                                       struct virtio_scsi_cmd_resp *resp_out)
 | |
| {
 | |
|     QVirtQueue *vq;
 | |
|     struct virtio_scsi_cmd_req req = { { 0 } };
 | |
|     struct virtio_scsi_cmd_resp resp = { .response = 0xff, .status = 0xff };
 | |
|     uint64_t req_addr, resp_addr, data_in_addr = 0, data_out_addr = 0;
 | |
|     uint8_t response;
 | |
|     uint32_t free_head;
 | |
| 
 | |
|     vq = vs->vq[2];
 | |
| 
 | |
|     req.lun[0] = 1; /* Select LUN */
 | |
|     req.lun[1] = 1; /* Select target 1 */
 | |
|     memcpy(req.cdb, cdb, VIRTIO_SCSI_CDB_SIZE);
 | |
| 
 | |
|     /* XXX: Fix endian if any multi-byte field in req/resp is used */
 | |
| 
 | |
|     /* Add request header */
 | |
|     req_addr = qvirtio_scsi_alloc(vs, sizeof(req), &req);
 | |
|     free_head = qvirtqueue_add(vq, req_addr, sizeof(req), false, true);
 | |
| 
 | |
|     if (data_out_len) {
 | |
|         data_out_addr = qvirtio_scsi_alloc(vs, data_out_len, data_out);
 | |
|         qvirtqueue_add(vq, data_out_addr, data_out_len, false, true);
 | |
|     }
 | |
| 
 | |
|     /* Add response header */
 | |
|     resp_addr = qvirtio_scsi_alloc(vs, sizeof(resp), &resp);
 | |
|     qvirtqueue_add(vq, resp_addr, sizeof(resp), true, !!data_in_len);
 | |
| 
 | |
|     if (data_in_len) {
 | |
|         data_in_addr = qvirtio_scsi_alloc(vs, data_in_len, data_in);
 | |
|         qvirtqueue_add(vq, data_in_addr, data_in_len, true, false);
 | |
|     }
 | |
| 
 | |
|     qvirtqueue_kick(vs->dev, vq, free_head);
 | |
|     qvirtio_wait_queue_isr(vs->dev, vq, QVIRTIO_SCSI_TIMEOUT_US);
 | |
| 
 | |
|     response = readb(resp_addr +
 | |
|                      offsetof(struct virtio_scsi_cmd_resp, response));
 | |
| 
 | |
|     if (resp_out) {
 | |
|         memread(resp_addr, resp_out, sizeof(*resp_out));
 | |
|     }
 | |
| 
 | |
|     guest_free(vs->qs->alloc, req_addr);
 | |
|     guest_free(vs->qs->alloc, resp_addr);
 | |
|     guest_free(vs->qs->alloc, data_in_addr);
 | |
|     guest_free(vs->qs->alloc, data_out_addr);
 | |
|     return response;
 | |
| }
 | |
| 
 | |
| static QVirtIOSCSI *qvirtio_scsi_pci_init(int slot)
 | |
| {
 | |
|     const uint8_t test_unit_ready_cdb[VIRTIO_SCSI_CDB_SIZE] = {};
 | |
|     QVirtIOSCSI *vs;
 | |
|     QVirtioPCIDevice *dev;
 | |
|     struct virtio_scsi_cmd_resp resp;
 | |
|     int i;
 | |
| 
 | |
|     vs = g_new0(QVirtIOSCSI, 1);
 | |
| 
 | |
|     vs->qs = qvirtio_scsi_start("-drive file=blkdebug::null-co://,"
 | |
|                                 "if=none,id=dr1,format=raw,file.align=4k "
 | |
|                                 "-device scsi-disk,drive=dr1,lun=0,scsi-id=1");
 | |
|     dev = qvirtio_pci_device_find(vs->qs->pcibus, VIRTIO_ID_SCSI);
 | |
|     vs->dev = (QVirtioDevice *)dev;
 | |
|     g_assert(dev != NULL);
 | |
|     g_assert_cmphex(vs->dev->device_type, ==, VIRTIO_ID_SCSI);
 | |
| 
 | |
|     qvirtio_pci_device_enable(dev);
 | |
|     qvirtio_reset(vs->dev);
 | |
|     qvirtio_set_acknowledge(vs->dev);
 | |
|     qvirtio_set_driver(vs->dev);
 | |
| 
 | |
|     vs->num_queues = qvirtio_config_readl(vs->dev, 0);
 | |
| 
 | |
|     g_assert_cmpint(vs->num_queues, <, MAX_NUM_QUEUES);
 | |
| 
 | |
|     for (i = 0; i < vs->num_queues + 2; i++) {
 | |
|         vs->vq[i] = qvirtqueue_setup(vs->dev, vs->qs->alloc, i);
 | |
|     }
 | |
| 
 | |
|     /* Clear the POWER ON OCCURRED unit attention */
 | |
|     g_assert_cmpint(virtio_scsi_do_command(vs, test_unit_ready_cdb,
 | |
|                                            NULL, 0, NULL, 0, &resp),
 | |
|                     ==, 0);
 | |
|     g_assert_cmpint(resp.status, ==, CHECK_CONDITION);
 | |
|     g_assert_cmpint(resp.sense[0], ==, 0x70); /* Fixed format sense buffer */
 | |
|     g_assert_cmpint(resp.sense[2], ==, UNIT_ATTENTION);
 | |
|     g_assert_cmpint(resp.sense[12], ==, 0x29); /* POWER ON */
 | |
|     g_assert_cmpint(resp.sense[13], ==, 0x00);
 | |
| 
 | |
|     return vs;
 | |
| }
 | |
| 
 | |
| /* Tests only initialization so far. TODO: Replace with functional tests */
 | |
| static void pci_nop(void)
 | |
| {
 | |
|     QOSState *qs;
 | |
| 
 | |
|     qs = qvirtio_scsi_start(NULL);
 | |
|     qvirtio_scsi_stop(qs);
 | |
| }
 | |
| 
 | |
| static void hotplug(void)
 | |
| {
 | |
|     QDict *response;
 | |
|     QOSState *qs;
 | |
| 
 | |
|     qs = qvirtio_scsi_start("-drive id=drv1,if=none,file=/dev/null,format=raw");
 | |
|     response = qmp("{\"execute\": \"device_add\","
 | |
|                    " \"arguments\": {"
 | |
|                    "   \"driver\": \"scsi-hd\","
 | |
|                    "   \"id\": \"scsi-hd\","
 | |
|                    "   \"drive\": \"drv1\""
 | |
|                    "}}");
 | |
| 
 | |
|     g_assert(response);
 | |
|     g_assert(!qdict_haskey(response, "error"));
 | |
|     QDECREF(response);
 | |
| 
 | |
|     response = qmp("{\"execute\": \"device_del\","
 | |
|                    " \"arguments\": {"
 | |
|                    "   \"id\": \"scsi-hd\""
 | |
|                    "}}");
 | |
| 
 | |
|     g_assert(response);
 | |
|     g_assert(!qdict_haskey(response, "error"));
 | |
|     g_assert(qdict_haskey(response, "event"));
 | |
|     g_assert(!strcmp(qdict_get_str(response, "event"), "DEVICE_DELETED"));
 | |
|     QDECREF(response);
 | |
|     qvirtio_scsi_stop(qs);
 | |
| }
 | |
| 
 | |
| /* Test WRITE SAME with the lba not aligned */
 | |
| static void test_unaligned_write_same(void)
 | |
| {
 | |
|     QVirtIOSCSI *vs;
 | |
|     uint8_t buf1[512] = { 0 };
 | |
|     uint8_t buf2[512] = { 1 };
 | |
|     const uint8_t write_same_cdb_1[VIRTIO_SCSI_CDB_SIZE] = {
 | |
|         0x41, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x02, 0x00
 | |
|     };
 | |
|     const uint8_t write_same_cdb_2[VIRTIO_SCSI_CDB_SIZE] = {
 | |
|         0x41, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x33, 0x00, 0x00
 | |
|     };
 | |
| 
 | |
|     vs = qvirtio_scsi_pci_init(PCI_SLOT);
 | |
| 
 | |
|     g_assert_cmphex(0, ==,
 | |
|         virtio_scsi_do_command(vs, write_same_cdb_1, NULL, 0, buf1, 512, NULL));
 | |
| 
 | |
|     g_assert_cmphex(0, ==,
 | |
|         virtio_scsi_do_command(vs, write_same_cdb_2, NULL, 0, buf2, 512, NULL));
 | |
| 
 | |
|     qvirtio_scsi_pci_free(vs);
 | |
| }
 | |
| 
 | |
| int main(int argc, char **argv)
 | |
| {
 | |
|     g_test_init(&argc, &argv, NULL);
 | |
|     qtest_add_func("/virtio/scsi/pci/nop", pci_nop);
 | |
|     qtest_add_func("/virtio/scsi/pci/hotplug", hotplug);
 | |
|     qtest_add_func("/virtio/scsi/pci/scsi-disk/unaligned-write-same",
 | |
|                    test_unaligned_write_same);
 | |
| 
 | |
|     return g_test_run();
 | |
| }
 |