mirror of
				https://github.com/qemu/qemu.git
				synced 2025-10-31 12:07:31 +00:00 
			
		
		
		
	 e178113ff6
			
		
	
	
		e178113ff6
		
	
	
	
	
		
			
			Several QOM type names contain ',':
    ARM,bitband-memory
    etraxfs,pic
    etraxfs,serial
    etraxfs,timer
    fsl,imx25
    fsl,imx31
    fsl,imx6
    fsl,imx6ul
    fsl,imx7
    grlib,ahbpnp
    grlib,apbpnp
    grlib,apbuart
    grlib,gptimer
    grlib,irqmp
    qemu,register
    SUNW,bpp
    SUNW,CS4231
    SUNW,DBRI
    SUNW,DBRI.prom
    SUNW,fdtwo
    SUNW,sx
    SUNW,tcx
    xilinx,zynq_slcr
    xlnx,zynqmp
    xlnx,zynqmp-pmu-soc
    xlnx,zynq-xadc
These are all device types.  They can't be plugged with -device /
device_add, except for xlnx,zynqmp-pmu-soc, and I doubt that one
actually works.
They *can* be used with -device / device_add to request help.
Usability is poor, though: you have to double the comma, like this:
    $ qemu-system-x86_64 -device SUNW,,fdtwo,help
Trap for the unwary.  The fact that this was broken in
device-introspect-test for more than six years until commit e27bd49876
fixed it demonstrates that "the unwary" includes seasoned developers.
One QOM type name contains ' ': "ICH9 SMB".  Because having to
remember just one way to quote would be too easy.
Rename the "SUNW,FOO types to "sun-FOO".  Summarily replace ',' and '
' by '-' in the other type names.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210304140229.575481-2-armbru@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
		
	
			
		
			
				
	
	
		
			58 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			58 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * GRLIB AHB APB PNP
 | |
|  *
 | |
|  *  Copyright (C) 2019 AdaCore
 | |
|  *
 | |
|  *  Developed by :
 | |
|  *  Frederic Konrad   <frederic.konrad@adacore.com>
 | |
|  *
 | |
|  * This program is free software; you can redistribute it and/or modify
 | |
|  * it under the terms of the GNU General Public License as published by
 | |
|  * the Free Software Foundation, either version 2 of the License, or
 | |
|  * (at your option) any later version.
 | |
|  *
 | |
|  * This program is distributed in the hope that it will be useful,
 | |
|  * but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
|  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
|  * GNU General Public License for more details.
 | |
|  *
 | |
|  * You should have received a copy of the GNU General Public License along
 | |
|  * with this program; if not, see <http://www.gnu.org/licenses/>.
 | |
|  *
 | |
|  */
 | |
| 
 | |
| #ifndef GRLIB_AHB_APB_PNP_H
 | |
| #define GRLIB_AHB_APB_PNP_H
 | |
| #include "qom/object.h"
 | |
| 
 | |
| #define TYPE_GRLIB_AHB_PNP "grlib-ahbpnp"
 | |
| OBJECT_DECLARE_SIMPLE_TYPE(AHBPnp, GRLIB_AHB_PNP)
 | |
| 
 | |
| #define TYPE_GRLIB_APB_PNP "grlib-apbpnp"
 | |
| OBJECT_DECLARE_SIMPLE_TYPE(APBPnp, GRLIB_APB_PNP)
 | |
| 
 | |
| void grlib_ahb_pnp_add_entry(AHBPnp *dev, uint32_t address, uint32_t mask,
 | |
|                              uint8_t vendor, uint16_t device, int slave,
 | |
|                              int type);
 | |
| void grlib_apb_pnp_add_entry(APBPnp *dev, uint32_t address, uint32_t mask,
 | |
|                              uint8_t vendor, uint16_t device, uint8_t version,
 | |
|                              uint8_t irq, int type);
 | |
| 
 | |
| /* VENDORS */
 | |
| #define GRLIB_VENDOR_GAISLER (0x01)
 | |
| /* DEVICES */
 | |
| #define GRLIB_LEON3_DEV      (0x03)
 | |
| #define GRLIB_APBMST_DEV     (0x06)
 | |
| #define GRLIB_APBUART_DEV    (0x0C)
 | |
| #define GRLIB_IRQMP_DEV      (0x0D)
 | |
| #define GRLIB_GPTIMER_DEV    (0x11)
 | |
| /* TYPE */
 | |
| #define GRLIB_CPU_AREA       (0x00)
 | |
| #define GRLIB_APBIO_AREA     (0x01)
 | |
| #define GRLIB_AHBMEM_AREA    (0x02)
 | |
| 
 | |
| #define GRLIB_AHB_MASTER     (0x00)
 | |
| #define GRLIB_AHB_SLAVE      (0x01)
 | |
| 
 | |
| #endif /* GRLIB_AHB_APB_PNP_H */
 |