mirror of
https://github.com/qemu/qemu.git
synced 2025-08-16 23:02:44 +00:00
eb013cd6a1
With a microvm-only build based on a custom device config,
we get a link failure due to undefined reference to
build_pci_host_bridge_osc_method() which is defined in hw/acpi/pci.c and
whose compilation depends on CONFIG_ACPI_PCI. Although CONFIG_ACPI
and CONFIG_PCI are set with such configuration, implied CONFIG_ACPI_PCI
in config PCI_EXPRESS_GENERIC_BRIDGE is not selected as expected.
It Looks like CONFIG_ACPI_PCI must be enforced and this patch selects
CONFIG_ACPI_PCI in MICROVM config directly as done for PC config.
Reproducer:
../configure \
--without-default-features \
--target-list=x86_64-softmmu \
--enable-kvm --disable-tcg \
--enable-pixman \
--enable-vnc \
--audio-drv-list="" \
--without-default-devices \
--with-devices-x86_64=microvm \
--enable-vhost-user
with configs/devices/x86_64-softmmu/microvm.mak:
CONFIG_PCI_DEVICES=n
CONFIG_MICROVM=y
CONFIG_VIRTIO_BLK=y
CONFIG_VIRTIO_SERIAL=y
CONFIG_VIRTIO_INPUT=y
CONFIG_VIRTIO_INPUT_HOST=y
CONFIG_VHOST_USER_INPUT=y
CONFIG_VIRTIO_NET=y
CONFIG_VIRTIO_SCSI=y
CONFIG_VIRTIO_RNG=y
CONFIG_VIRTIO_CRYPTO=y
CONFIG_VIRTIO_BALLOON=y
CONFIG_VIRTIO_GPU=y
CONFIG_VHOST_USER_GPU=y
FAILED: qemu-system-x86_64
cc -m64 @qemu-system-x86_64.rsp
/usr/bin/ld: libsystem.a.p/hw_pci-host_gpex-acpi.c.o: in function `acpi_dsdt_add_host_bridge_methods':
hw/pci-host/gpex-acpi.c:83:(.text+0x274): undefined reference to `build_pci_host_bridge_osc_method'
collect2: error: ld returned 1 exit status
Fixes:
|
||
|---|---|---|
| .. | ||
| kvm | ||
| xen | ||
| acpi-build.c | ||
| acpi-build.h | ||
| acpi-common.c | ||
| acpi-common.h | ||
| acpi-microvm.c | ||
| acpi-microvm.h | ||
| amd_iommu-stub.c | ||
| amd_iommu.c | ||
| amd_iommu.h | ||
| e820_memory_layout.c | ||
| e820_memory_layout.h | ||
| fw_cfg.c | ||
| fw_cfg.h | ||
| intel_iommu_internal.h | ||
| intel_iommu.c | ||
| Kconfig | ||
| meson.build | ||
| microvm-dt.c | ||
| microvm-dt.h | ||
| microvm.c | ||
| monitor.c | ||
| multiboot.c | ||
| multiboot.h | ||
| nitro_enclave.c | ||
| pc_piix.c | ||
| pc_q35.c | ||
| pc_sysfw_ovmf-stubs.c | ||
| pc_sysfw_ovmf.c | ||
| pc_sysfw.c | ||
| pc.c | ||
| port92.c | ||
| sgx-epc.c | ||
| sgx-stub.c | ||
| sgx.c | ||
| tdvf-hob.c | ||
| tdvf-hob.h | ||
| tdvf.c | ||
| trace-events | ||
| trace.h | ||
| vapic.c | ||
| vmmouse.c | ||
| vmport.c | ||
| x86-common.c | ||
| x86-cpu.c | ||
| x86-iommu-stub.c | ||
| x86-iommu.c | ||
| x86.c | ||