mirror of
https://github.com/qemu/qemu.git
synced 2025-08-09 01:50:43 +00:00
31995cc408
QEMU start failed when smp cpu < smp maxcpus , because qemu send a NULL cpu to KVM, this patch adds a check for kvm_ipi_access_regs() to fix it. run with '-smp 1,maxcpus=4,sockets=4,cores=1,threads=1' we got: Unexpected error in kvm_device_access() at ../accel/kvm/kvm-all.c:3477: qemu-system-loongarch64: KVM_SET_DEVICE_ATTR failed: Group 1073741825 attr 0x0000000000010000: Invalid argument Signed-off-by: Song Gao <gaosong@loongson.cn> Reviewed-by: Bibo Mao <maobibo@loongson.cn> Message-ID: <20250725081213.3867592-1-gaosong@loongson.cn>
91 lines
2.3 KiB
C
91 lines
2.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* LoongArch IPI interrupt KVM support
|
|
*
|
|
* Copyright (C) 2025 Loongson Technology Corporation Limited
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/error.h"
|
|
#include "hw/intc/loongarch_ipi.h"
|
|
#include "system/kvm.h"
|
|
#include "target/loongarch/cpu.h"
|
|
|
|
static void kvm_ipi_access_reg(int fd, uint64_t addr, uint32_t *val, bool write)
|
|
{
|
|
kvm_device_access(fd, KVM_DEV_LOONGARCH_IPI_GRP_REGS,
|
|
addr, val, write, &error_abort);
|
|
}
|
|
|
|
static void kvm_ipi_access_regs(void *opaque, bool write)
|
|
{
|
|
LoongsonIPICommonState *ipi = (LoongsonIPICommonState *)opaque;
|
|
LoongarchIPIState *lis = LOONGARCH_IPI(opaque);
|
|
IPICore *core;
|
|
uint64_t attr;
|
|
int i, cpu_index, fd = lis->dev_fd;
|
|
|
|
if (fd == 0) {
|
|
return;
|
|
}
|
|
|
|
for (i = 0; i < ipi->num_cpu; i++) {
|
|
core = &ipi->cpu[i];
|
|
if (core->cpu == NULL) {
|
|
continue;
|
|
}
|
|
cpu_index = i;
|
|
|
|
attr = (cpu_index << 16) | CORE_STATUS_OFF;
|
|
kvm_ipi_access_reg(fd, attr, &core->status, write);
|
|
|
|
attr = (cpu_index << 16) | CORE_EN_OFF;
|
|
kvm_ipi_access_reg(fd, attr, &core->en, write);
|
|
|
|
attr = (cpu_index << 16) | CORE_SET_OFF;
|
|
kvm_ipi_access_reg(fd, attr, &core->set, write);
|
|
|
|
attr = (cpu_index << 16) | CORE_CLEAR_OFF;
|
|
kvm_ipi_access_reg(fd, attr, &core->clear, write);
|
|
|
|
attr = (cpu_index << 16) | CORE_BUF_20;
|
|
kvm_ipi_access_reg(fd, attr, &core->buf[0], write);
|
|
|
|
attr = (cpu_index << 16) | CORE_BUF_28;
|
|
kvm_ipi_access_reg(fd, attr, &core->buf[2], write);
|
|
|
|
attr = (cpu_index << 16) | CORE_BUF_30;
|
|
kvm_ipi_access_reg(fd, attr, &core->buf[4], write);
|
|
|
|
attr = (cpu_index << 16) | CORE_BUF_38;
|
|
kvm_ipi_access_reg(fd, attr, &core->buf[6], write);
|
|
}
|
|
}
|
|
|
|
int kvm_ipi_get(void *opaque)
|
|
{
|
|
kvm_ipi_access_regs(opaque, false);
|
|
return 0;
|
|
}
|
|
|
|
int kvm_ipi_put(void *opaque, int version_id)
|
|
{
|
|
kvm_ipi_access_regs(opaque, true);
|
|
return 0;
|
|
}
|
|
|
|
void kvm_ipi_realize(DeviceState *dev, Error **errp)
|
|
{
|
|
LoongarchIPIState *lis = LOONGARCH_IPI(dev);
|
|
int ret;
|
|
|
|
ret = kvm_create_device(kvm_state, KVM_DEV_TYPE_LOONGARCH_IPI, false);
|
|
if (ret < 0) {
|
|
fprintf(stderr, "IPI KVM_CREATE_DEVICE failed: %s\n",
|
|
strerror(-ret));
|
|
abort();
|
|
}
|
|
|
|
lis->dev_fd = ret;
|
|
}
|