7 Commits

Author	SHA1	Message	Date
Cameron Esfahani	8c3b0e9e67	hvf: correctly handle REX prefix in relation to legacy prefixes ... In real x86 processors, the REX prefix must come after legacy prefixes. REX before legacy is ignored. Update the HVF emulation code to properly handle this. Fix some spelling errors in constants. Fix some decoder table initialization issues found by Coverity. Signed-off-by: Cameron Esfahani <dirty@apple.com> Message-Id: <eff30ded8307471936bec5d84c3b6efbc95e3211.1574625592.git.dirty@apple.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>	2019-11-26 09:58:36 +01:00
Markus Armbruster	177d9e0da0	Normalize header guard symbol definition. ... We commonly define the header guard symbol without an explicit value. Normalize the exceptions. Done with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20190315145123.28030-8-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>	2019-05-13 08:58:55 +02:00
Roman Bolshakov	b4e1af8961	i386: hvf: Fix register refs if REX is present ... According to Intel(R)64 and IA-32 Architectures Software Developer's Manual, the following one-byte registers should be fetched when REX prefix is present (sorted by reg encoding index): AL, CL, DL, BL, SPL, BPL, SIL, DIL, R8L - R15L The first 8 are fetched if REX.R is zero, the last 8 if non-zero. The following registers should be fetched for instructions without REX prefix (also sorted by reg encoding index): AL, CL, DL, BL, AH, CH, DH, BH Current emulation code doesn't handle accesses to SPL, BPL, SIL, DIL when REX is present, thefore an instruction 40883e "mov %dil,(%rsi)" is decoded as "mov %bh,(%rsi)". That caused an infinite loop in vp_reset: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg03293.html Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com> Message-Id: <20181018134401.44471-1-r.bolshakov@yadro.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>	2018-10-19 13:44:12 +02:00
Paolo Bonzini	ff2de1668c	i386: hvf: remove addr_t ... Use target_ulong for virtual addresses and uint64_t for physical addresses. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>	2017-12-22 15:02:07 +01:00
Paolo Bonzini	6701d81d74	i386: hvf: unify register enums between HVF and the rest ... Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>	2017-12-22 15:02:07 +01:00
Paolo Bonzini	f9fea77740	i386: hvf: header cleanup ... Remove inclusions of system headers and avoid "pragma once". Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>	2017-12-22 15:02:07 +01:00
Paolo Bonzini	69e0a03c3f	i386: hvf: move all hvf files in the same directory ... Just call it hvf/, no need for the "utils" suffix. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>	2017-12-22 15:02:05 +01:00