Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-10 21:34:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

target-ppc: gdbstub: fix altivec registers for little-endian guests

Browse Source 
Altivec registers are 128-bit wide. They are stored in memory as two
64-bit values that must be byteswapped when the guest is little-endian.
Let's reuse the ppc_maybe_bswap_register() helper for this.

We also need to fix the ordering of the 64-bit elements according to
the target endianness, for both system and user mode.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Greg Kurz 2016-01-15 16:00:38 +01:00 committed by David Gibson
parent 87601e2d5c
commit ea499e7150
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
target-ppc/translate_init.c
View File

@ -8753,9 +8753,9 @@ static void dump_ppc_insns (CPUPPCState *env)
static bool avr_need_swap(CPUPPCState *env) static bool avr_need_swap(CPUPPCState *env)
{ {
#ifdef HOST_WORDS_BIGENDIAN #ifdef HOST_WORDS_BIGENDIAN
return false; return msr_le;
#else #else
return true; return !msr_le;
#endif #endif
} }
@ -8799,14 +8799,18 @@ static int gdb_get_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n)
stq_p(mem_buf, env->avr[n].u64[1]); stq_p(mem_buf, env->avr[n].u64[1]);
stq_p(mem_buf+8, env->avr[n].u64[0]); stq_p(mem_buf+8, env->avr[n].u64[0]);
} }
ppc_maybe_bswap_register(env, mem_buf, 8);
ppc_maybe_bswap_register(env, mem_buf + 8, 8);
return 16; return 16;
} }
if (n == 32) { if (n == 32) {
stl_p(mem_buf, env->vscr); stl_p(mem_buf, env->vscr);
ppc_maybe_bswap_register(env, mem_buf, 4);
return 4; return 4;
} }
if (n == 33) { if (n == 33) {
stl_p(mem_buf, (uint32_t)env->spr[SPR_VRSAVE]); stl_p(mem_buf, (uint32_t)env->spr[SPR_VRSAVE]);
ppc_maybe_bswap_register(env, mem_buf, 4);
return 4; return 4;
} }
return 0; return 0;
@ -8815,6 +8819,8 @@ static int gdb_get_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n)
static int gdb_set_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n) static int gdb_set_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n)
{ {
if (n < 32) { if (n < 32) {
ppc_maybe_bswap_register(env, mem_buf, 8);
ppc_maybe_bswap_register(env, mem_buf + 8, 8);
if (!avr_need_swap(env)) { if (!avr_need_swap(env)) {
env->avr[n].u64[0] = ldq_p(mem_buf); env->avr[n].u64[0] = ldq_p(mem_buf);
env->avr[n].u64[1] = ldq_p(mem_buf+8); env->avr[n].u64[1] = ldq_p(mem_buf+8);
@ -8825,10 +8831,12 @@ static int gdb_set_avr_reg(CPUPPCState *env, uint8_t *mem_buf, int n)
return 16; return 16;
} }
if (n == 32) { if (n == 32) {
ppc_maybe_bswap_register(env, mem_buf, 4);
env->vscr = ldl_p(mem_buf); env->vscr = ldl_p(mem_buf);
return 4; return 4;
} }
if (n == 33) { if (n == 33) {
ppc_maybe_bswap_register(env, mem_buf, 4);
env->spr[SPR_VRSAVE] = (target_ulong)ldl_p(mem_buf); env->spr[SPR_VRSAVE] = (target_ulong)ldl_p(mem_buf);
return 4; return 4;
} }