Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-15 22:31:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qxl: fix modular builds with dtrace

Browse Source 
Checking the enable/disable state of tracepoints via
trace_event_get_state_backends() does not work for modules.

qxl checks the state for a small optimization (avoid g_strndup
call in case log_buf will not be used anyway), so we can just
drop that check for modular builds.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20200720100352.2477-2-kraxel@redhat.com>
This commit is contained in:
Gerd Hoffmann 2020-07-20 12:03:50 +02:00
parent 8e67fda2dd
commit d97df4b84b
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hw/display/qxl.c
View File

@ -1762,7 +1762,16 @@ async_common:
qxl_set_mode(d, val, 0); qxl_set_mode(d, val, 0);
break; break;
case QXL_IO_LOG: case QXL_IO_LOG:
#ifdef CONFIG_MODULES
/*
* FIXME
* trace_event_get_state_backends() does not work for modules,
* it leads to "undefined symbol: qemu_qxl_io_log_semaphore"
*/
if (true) {
#else
if (trace_event_get_state_backends(TRACE_QXL_IO_LOG) || d->guestdebug) { if (trace_event_get_state_backends(TRACE_QXL_IO_LOG) || d->guestdebug) {
#endif
/* We cannot trust the guest to NUL terminate d->ram->log_buf */ /* We cannot trust the guest to NUL terminate d->ram->log_buf */
char *log_buf = g_strndup((const char *)d->ram->log_buf, char *log_buf = g_strndup((const char *)d->ram->log_buf,
sizeof(d->ram->log_buf)); sizeof(d->ram->log_buf));