mirror of
https://github.com/qemu/qemu.git
synced 2025-08-14 11:43:46 +00:00
overall: Remove unnecessary g_strdup_printf() calls
Replace g_strdup_printf("%s", value) -> g_strdup(value) to avoid unnecessary string formatting. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
parent
ce315328f8
commit
9038ac0c5c
@ -59,7 +59,7 @@ qcrypto_afalg_hash_format_name(QCryptoHashAlgo alg,
|
||||
if (is_hmac) {
|
||||
name = g_strdup_printf("hmac(%s)", alg_name);
|
||||
} else {
|
||||
name = g_strdup_printf("%s", alg_name);
|
||||
name = g_strdup(alg_name);
|
||||
}
|
||||
|
||||
return name;
|
||||
|
@ -1034,7 +1034,7 @@ void spapr_caps_add_properties(SpaprMachineClass *smc)
|
||||
for (i = 0; i < ARRAY_SIZE(capability_table); i++) {
|
||||
SpaprCapabilityInfo *cap = &capability_table[i];
|
||||
g_autofree char *name = g_strdup_printf("cap-%s", cap->name);
|
||||
g_autofree char *desc = g_strdup_printf("%s", cap->description);
|
||||
g_autofree char *desc = g_strdup(cap->description);
|
||||
|
||||
object_class_property_add(klass, name, cap->type,
|
||||
cap->get, cap->set,
|
||||
|
@ -128,7 +128,7 @@ static int plugin_add(void *opaque, const char *name, const char *value,
|
||||
/* Will treat arg="argname" as "argname=on" */
|
||||
fullarg = g_strdup_printf("%s=%s", value, "on");
|
||||
} else {
|
||||
fullarg = g_strdup_printf("%s", value);
|
||||
fullarg = g_strdup(value);
|
||||
}
|
||||
warn_report("using 'arg=%s' is deprecated", value);
|
||||
error_printf("Please use '%s' directly\n", fullarg);
|
||||
|
@ -6166,7 +6166,7 @@ static void x86_cpu_list_entry(gpointer data, gpointer user_data)
|
||||
desc = g_strdup_printf("%s [%s]", model_id, cc->model->note);
|
||||
}
|
||||
if (!desc) {
|
||||
desc = g_strdup_printf("%s", model_id);
|
||||
desc = g_strdup(model_id);
|
||||
}
|
||||
|
||||
if (cc->model && cc->model->cpudef->deprecation_note) {
|
||||
|
@ -366,7 +366,7 @@ void st_set_trace_file(const char *file)
|
||||
/* Type cast needed for Windows where getpid() returns an int. */
|
||||
trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE "-" FMT_pid, (pid_t)getpid());
|
||||
} else {
|
||||
trace_file_name = g_strdup_printf("%s", file);
|
||||
trace_file_name = g_strdup(file);
|
||||
}
|
||||
|
||||
st_set_trace_file_enabled(saved_enable);
|
||||
|
@ -1386,9 +1386,7 @@ char *qemu_console_get_label(QemuConsole *con)
|
||||
object_get_typename(c->device),
|
||||
c->head);
|
||||
} else {
|
||||
return g_strdup_printf("%s", dev->id ?
|
||||
dev->id :
|
||||
object_get_typename(c->device));
|
||||
return g_strdup(dev->id ? : object_get_typename(c->device));
|
||||
}
|
||||
}
|
||||
return g_strdup("VGA");
|
||||
|
3
ui/gtk.c
3
ui/gtk.c
@ -1944,8 +1944,7 @@ static GSList *gd_vc_vte_init(GtkDisplayState *s, VirtualConsole *vc,
|
||||
vcd->console = vc;
|
||||
|
||||
snprintf(buffer, sizeof(buffer), "vc%d", idx);
|
||||
vc->label = g_strdup_printf("%s", vc->vte.chr->label
|
||||
? vc->vte.chr->label : buffer);
|
||||
vc->label = g_strdup(vc->vte.chr->label ? : buffer);
|
||||
group = gd_vc_menu_init(s, vc, idx, group, view_menu);
|
||||
|
||||
vc->vte.terminal = vte_terminal_new();
|
||||
|
@ -234,7 +234,7 @@ int module_load(const char *prefix, const char *name, Error **errp)
|
||||
|
||||
search_dir = getenv("QEMU_MODULE_DIR");
|
||||
if (search_dir != NULL) {
|
||||
dirs[n_dirs++] = g_strdup_printf("%s", search_dir);
|
||||
dirs[n_dirs++] = g_strdup(search_dir);
|
||||
}
|
||||
dirs[n_dirs++] = get_relocated_path(CONFIG_QEMU_MODDIR);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user