Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-16 14:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

e1000e: correctly tear down MSI-X memory regions

Browse Source 
MSI-X has been disabled by the time the e1000e device is unrealized, hence
msix_uninit is never called.  This causes the object to be leaked, which
shows up as a RAMBlock with empty name when attempting migration.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Tested-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
This commit is contained in:
Paolo Bonzini 2017-03-09 12:58:30 +01:00 committed by Jason Wang
parent 5bac3c39c8
commit 7ec7ae4b97
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/net/e1000e.c
View File

@ -306,7 +306,7 @@ e1000e_init_msix(E1000EState *s)
static void static void
e1000e_cleanup_msix(E1000EState *s) e1000e_cleanup_msix(E1000EState *s)
{ {
if (msix_enabled(PCI_DEVICE(s))) { if (msix_present(PCI_DEVICE(s))) {
e1000e_unuse_msix_vectors(s, E1000E_MSIX_VEC_NUM); e1000e_unuse_msix_vectors(s, E1000E_MSIX_VEC_NUM);
msix_uninit(PCI_DEVICE(s), &s->msix, &s->msix); msix_uninit(PCI_DEVICE(s), &s->msix, &s->msix);
} }