Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-15 05:06:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

hw/core/loader: Fix type conflict of GLib function pointers

Browse Source 
On Emscripten, function pointer casts can result in runtime failures due to
strict function signature checks. This affects the use of g_list_sort and
g_slist_sort, which internally perform function pointer casts that are not
supported by Emscripten. To avoid these issues, g_list_sort_with_data and
g_slist_sort_with_data should be used instead, as they do not rely on
function pointer casting.

Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <26dfe9191154ca65dca6ef51ce768ad2a0c30d5f.1745295397.git.ktokunaga.mail@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Kohei Tokunaga 2025-04-22 14:27:05 +09:00 committed by Philippe Mathieu-Daudé
parent 8cd3b84c8a
commit 604ac1d87b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/core/loader.c
View File

@ -1410,7 +1410,7 @@ typedef struct RomSec {
* work, but this way saves a little work later by avoiding * work, but this way saves a little work later by avoiding
* dealing with "gaps" of 0 length. * dealing with "gaps" of 0 length.
*/ */
static gint sort_secs(gconstpointer a, gconstpointer b) static gint sort_secs(gconstpointer a, gconstpointer b, gpointer d)
{ {
RomSec *ra = (RomSec *) a; RomSec *ra = (RomSec *) a;
RomSec *rb = (RomSec *) b; RomSec *rb = (RomSec *) b;
@ -1463,7 +1463,7 @@ RomGap rom_find_largest_gap_between(hwaddr base, size_t size)
/* sentinel */ /* sentinel */
secs = add_romsec_to_list(secs, base + size, 1); secs = add_romsec_to_list(secs, base + size, 1);
secs = g_list_sort(secs, sort_secs); secs = g_list_sort_with_data(secs, sort_secs, NULL);
for (it = g_list_first(secs); it; it = g_list_next(it)) { for (it = g_list_first(secs); it; it = g_list_next(it)) {
cand = (RomSec *) it->data; cand = (RomSec *) it->data;