Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-14 11:43:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

hw/loader: Clarify local variable name in load_elf_ram_sym()

Browse Source 
load_elf_ram_sym() compares target_data_order versus
host data_order. Rename 'data_order' -> 'host_data_order'
to ease code review. Avoid the preprocessor by directly
checking HOST_BIG_ENDIAN.

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20250127113824.50177-4-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2025-01-26 14:54:00 +01:00
parent ff12b602fc
commit 518f8fdfe2
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hw/core/loader.c
View File

@ -443,7 +443,8 @@ ssize_t load_elf_ram_sym(const char *filename,
int clear_lsb, int data_swab, int clear_lsb, int data_swab,
AddressSpace *as, bool load_rom, symbol_fn_t sym_cb) AddressSpace *as, bool load_rom, symbol_fn_t sym_cb)
{ {
int fd, data_order, target_data_order, must_swab; const int host_data_order = HOST_BIG_ENDIAN ? ELFDATA2MSB : ELFDATA2LSB;
int fd, target_data_order, must_swab;
ssize_t ret = ELF_LOAD_FAILED; ssize_t ret = ELF_LOAD_FAILED;
uint8_t e_ident[EI_NIDENT]; uint8_t e_ident[EI_NIDENT];
@ -461,12 +462,7 @@ ssize_t load_elf_ram_sym(const char *filename,
ret = ELF_LOAD_NOT_ELF; ret = ELF_LOAD_NOT_ELF;
goto fail; goto fail;
} }
#if HOST_BIG_ENDIAN must_swab = host_data_order != e_ident[EI_DATA];
data_order = ELFDATA2MSB;
#else
data_order = ELFDATA2LSB;
#endif
must_swab = data_order != e_ident[EI_DATA];
if (big_endian) { if (big_endian) {
target_data_order = ELFDATA2MSB; target_data_order = ELFDATA2MSB;
} else { } else {