Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-06 21:55:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vl: Rewrite a fall through comment

Browse Source 
GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

  vl.c: In function ‘qemu_ref_timedate’:
  vl.c:773:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
    773 |         value -= rtc_realtime_clock_offset;
        |         ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  vl.c:775:5: note: here
    775 |     case QEMU_CLOCK_VIRTUAL:
        |     ^~~~
  cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20190719131425.10835-7-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Philippe Mathieu-Daudé 2019-07-19 15:14:24 +02:00 committed by Laurent Vivier
parent b1d5b6e507
commit 4e8de60623
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vl.c
View File

@ -772,7 +772,7 @@ static time_t qemu_ref_timedate(QEMUClockType clock)
switch (clock) { switch (clock) {
case QEMU_CLOCK_REALTIME: case QEMU_CLOCK_REALTIME:
value -= rtc_realtime_clock_offset; value -= rtc_realtime_clock_offset;
/* no break */ /* fall through */
case QEMU_CLOCK_VIRTUAL: case QEMU_CLOCK_VIRTUAL:
value += rtc_ref_start_datetime; value += rtc_ref_start_datetime;
break; break;