Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-10 03:59:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vhost-net: revert support of cross-endian vnet headers

Browse Source 
Cross-endian is now handled by the core virtio-net code.

This patch reverts:

commit 5be7d9f1b1
	vhost-net: tell tap backend about the vnet endianness

and

commit cf0a628f6e81bfc9b7a944fa0b80c3594836df56
	net: set endianness on all backend devices

Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
This commit is contained in:
Greg Kurz 2016-02-05 11:45:26 +01:00 committed by Michael S. Tsirkin
parent 1bfa316ce7
commit 3154d1e426
1 changed files with 5 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
hw/net/vhost_net.c
View File

@ -36,7 +36,6 @@
#include "standard-headers/linux/virtio_ring.h" #include "standard-headers/linux/virtio_ring.h"
#include "hw/virtio/vhost.h" #include "hw/virtio/vhost.h"
#include "hw/virtio/virtio-bus.h" #include "hw/virtio/virtio-bus.h"
#include "hw/virtio/virtio-access.h"
struct vhost_net { struct vhost_net {
struct vhost_dev dev; struct vhost_dev dev;
@ -197,27 +196,6 @@ static void vhost_net_set_vq_index(struct vhost_net *net, int vq_index)
net->dev.vq_index = vq_index; net->dev.vq_index = vq_index;
} }
static int vhost_net_set_vnet_endian(VirtIODevice *dev, NetClientState *peer,
bool set)
{
int r = 0;
if (virtio_vdev_has_feature(dev, VIRTIO_F_VERSION_1) ||
(virtio_legacy_is_cross_endian(dev) && !virtio_is_big_endian(dev))) {
r = qemu_set_vnet_le(peer, set);
if (r) {
error_report("backend does not support LE vnet headers");
}
} else if (virtio_legacy_is_cross_endian(dev)) {
r = qemu_set_vnet_be(peer, set);
if (r) {
error_report("backend does not support BE vnet headers");
}
}
return r;
}
static int vhost_net_start_one(struct vhost_net *net, static int vhost_net_start_one(struct vhost_net *net,
VirtIODevice *dev) VirtIODevice *dev)
{ {
@ -298,25 +276,21 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(dev))); BusState *qbus = BUS(qdev_get_parent_bus(DEVICE(dev)));
VirtioBusState *vbus = VIRTIO_BUS(qbus); VirtioBusState *vbus = VIRTIO_BUS(qbus);
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus); VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
int r, e, i, j; int r, e, i;
if (!k->set_guest_notifiers) { if (!k->set_guest_notifiers) {
error_report("binding does not support guest notifiers"); error_report("binding does not support guest notifiers");
return -ENOSYS; return -ENOSYS;
} }
for (j = 0; j < total_queues; j++) { for (i = 0; i < total_queues; i++) {
r = vhost_net_set_vnet_endian(dev, ncs[j].peer, true); vhost_net_set_vq_index(get_vhost_net(ncs[i].peer), i * 2);
if (r < 0) {
goto err_endian;
}
vhost_net_set_vq_index(get_vhost_net(ncs[j].peer), j * 2);
} }
r = k->set_guest_notifiers(qbus->parent, total_queues * 2, true); r = k->set_guest_notifiers(qbus->parent, total_queues * 2, true);
if (r < 0) { if (r < 0) {
error_report("Error binding guest notifier: %d", -r); error_report("Error binding guest notifier: %d", -r);
goto err_endian; goto err;
} }
for (i = 0; i < total_queues; i++) { for (i = 0; i < total_queues; i++) {
@ -338,10 +312,7 @@ err_start:
fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", e); fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", e);
fflush(stderr); fflush(stderr);
} }
err_endian: err:
while (--j >= 0) {
vhost_net_set_vnet_endian(dev, ncs[j].peer, false);
}
return r; return r;
} }
@ -363,8 +334,6 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState *ncs,
fflush(stderr); fflush(stderr);
} }
assert(r >= 0); assert(r >= 0);
assert(vhost_net_set_vnet_endian(dev, ncs[0].peer, false) >= 0);
} }
void vhost_net_cleanup(struct vhost_net *net) void vhost_net_cleanup(struct vhost_net *net)