Proxmox-Port/qemu
1
0
Fork 0
mirror of https://github.com/qemu/qemu.git synced 2025-08-15 22:02:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

qga: Don't access global variable in run_agent_once()

Browse Source 
The run_agent_once() function is already given GAState via an
argument. There's no need to access the global ga_state variable
which points to the argument anyways (thanks to
initialize_agent()). Worse, some parts of the function use the
argument and the other use the global variable.  Stick with the
function argument.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Link: https://lore.kernel.org/r/8ae7f5d5032b14a5b956fe8aaf47bae5ca401699.1733414906.git.mprivozn@redhat.com
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
This commit is contained in:
Michal Privoznik 2024-12-05 17:18:45 +01:00 committed by Konstantin Kostiuk
parent 5788e96024
commit 2657a92b54
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qga/main.c
View File

@ -1519,7 +1519,7 @@ static int run_agent_once(GAState *s)
return EXIT_FAILURE;
}
g_main_loop_run(ga_state->main_loop);
g_main_loop_run(s->main_loop);
if (s->channel) {
ga_channel_free(s->channel);