From 067a0f55bbf155936861d8844c91dfc16b883c1d Mon Sep 17 00:00:00 2001 From: Christoph Heiss Date: Mon, 4 Aug 2025 15:29:56 +0200 Subject: [PATCH] vmstate: improve cleaning up dbus-vmstate and avoid spurious warning First, moving to vm_stop_cleanup(), which is a better fit for this. It gets called by the cleanup API method in case of unclean shutdown or from inside the guest. In every case, the dbus-vmstate daemon should _never_ be running at this point, as it is started only before migration and stopped directly after migration, before vm_stop_cleanup() is even called. So it should only be left running in case of a crash during migration. Calling it anyway here ensures that the daemon is always (cleanly) shut down. As the dbus-vmstate is part of the VM scope unit, that would it tear it down too as a last resort. Fixes the following spurious warning when a VM was shutdown from inside the guest: `failed to retrieve org.qemu.VMState1 owners: org.freedesktop.DBus.Error.NameHasNoOwner: Could not get owners of name 'org.qemu.VMState1': no such name` Reported-by: Hannes Duerr Reported-by: Maximiliano Sandoval Signed-off-by: Christoph Heiss Link: https://lore.proxmox.com/20250804133002.1625925-1-c.heiss@proxmox.com Signed-off-by: Thomas Lamprecht --- src/PVE/CLI/qm.pm | 3 --- src/PVE/QemuServer.pm | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index 3e778ad1..2e56e234 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -1056,9 +1056,6 @@ __PACKAGE__->register_method({ PVE::QemuServer::vm_stop_cleanup($storecfg, $vmid, $conf, 0, 0, 1); } - # ensure that no dbus-vmstate helper is left running in any case - PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($vmid); - PVE::GuestHelpers::exec_hookscript($conf, $vmid, 'post-stop'); $restart = eval { PVE::QemuServer::clear_reboot_request($vmid) }; diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 34d251a7..30ec58b1 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -6102,6 +6102,8 @@ sub vm_stop_cleanup { my ($storecfg, $vmid, $conf, $keepActive, $apply_pending_changes, $noerr) = @_; eval { + # ensure that no dbus-vmstate helper is left running in any case + PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($vmid, quiet => $noerr); if (!$keepActive) { my $vollist = get_vm_volumes($conf);