Proxmox-Port/proxmox
1
0
Fork 0
forked from proxmox-mirrors/proxmox
Code Pull Requests Activity

rrd: cache: add update_value_ignore_old

Browse Source 
This function is the same as the regular `update_value`, but it
sets the `new_only` flag when updating the value in the rrd map.
This avoids "time in past" messages being logged in case a data point
happens to be added twice. This new function will just silently reject
values that have an older timestamp than the most recent one.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
This commit is contained in:
Lukas Wagner 2024-08-06 14:59:52 +02:00 committed by Wolfgang Bumiller
parent 4ca2e01442
commit f01c1e0ce9
1 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
proxmox-rrd/src/cache.rs
View File

@ -190,6 +190,32 @@ impl Cache {
time: f64,
value: f64,
dst: DataSourceType,
) -> Result<(), Error> {
self.update_value_impl(rel_path, time, value, dst, false)
}
/// Update data in RAM and write file back to disk (journal)
///
/// This method is equivalent to `update_value`, but it ignores
/// the call if `time` is older than any previously stored data point.
/// A journal entry will still be created, but then also ignored when applying.
pub fn update_value_ignore_old(
&self,
rel_path: &str,
time: f64,
value: f64,
dst: DataSourceType,
) -> Result<(), Error> {
self.update_value_impl(rel_path, time, value, dst, true)
}
fn update_value_impl(
&self,
rel_path: &str,
time: f64,
value: f64,
dst: DataSourceType,
new_only: bool,
) -> Result<(), Error> {
let journal_applied = self.apply_journal()?;
@ -202,7 +228,7 @@ impl Cache {
self.rrd_map
.write()
.unwrap()
.update(rel_path, time, value, dst, false)?;
.update(rel_path, time, value, dst, new_only)?;
}
Ok(())