Proxmox-Port/proxmox
1
0
Fork 0
forked from proxmox-mirrors/proxmox
Code Pull Requests Activity

client: use correct error for protocol errors

Browse Source 
The 'Anyhow' error is not useful and meant for throw-away errors which
cannot be dealt with anyway, and we'd like to be able to tell apart
network problems from actual HTTP responses, so that we can
potentially try a different node in a cluster connection.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
This commit is contained in:
Wolfgang Bumiller 2024-11-19 13:38:13 +01:00
parent c01318d966
commit 96e76d7f72
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
proxmox-client/src/client.rs
View File

@ -223,7 +223,10 @@ impl Client {
} }
.map_err(|err| Error::internal("failed to build request", err))?; .map_err(|err| Error::internal("failed to build request", err))?;
let response = client.request(request).await.map_err(Error::Anyhow)?; let response = client
.request(request)
.await
.map_err(|err| Error::Client(err.into()))?;
if response.status() == StatusCode::UNAUTHORIZED { if response.status() == StatusCode::UNAUTHORIZED {
return Err(Error::Unauthorized); return Err(Error::Unauthorized);
@ -318,7 +321,11 @@ impl Client {
.body(request.body.into()) .body(request.body.into())
.map_err(|err| Error::internal("error building login http request", err))?; .map_err(|err| Error::internal("error building login http request", err))?;
let api_response = self.client.request(request).await.map_err(Error::Anyhow)?; let api_response = self
.client
.request(request)
.await
.map_err(|err| Error::Client(err.into()))?;
if !api_response.status().is_success() { if !api_response.status().is_success() {
return Err(Error::api(api_response.status(), "authentication failed")); return Err(Error::api(api_response.status(), "authentication failed"));
} }