Proxmox-Port/proxmox
1
0
Fork 0
forked from proxmox-mirrors/proxmox
Code Pull Requests Activity

websocket: add note about compat removal

Browse Source 
this major release still needs to have an incompatible, the next one can
drop setting a protocol client-side, and the one after that can remove
the protocol handling on the server side.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
This commit is contained in:
Fabian Grünbichler 2021-05-18 09:23:37 +02:00
parent 0786b4b98c
commit 480e213f7c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
proxmox-http/src/websocket/mod.rs
View File

@ -692,6 +692,8 @@ impl WebSocket {
.header(CONNECTION, HeaderValue::from_static("Upgrade")) .header(CONNECTION, HeaderValue::from_static("Upgrade"))
.header(SEC_WEBSOCKET_ACCEPT, response_key); .header(SEC_WEBSOCKET_ACCEPT, response_key);
// FIXME: remove compat in PBS 3.x
//
// We currently do not support any subprotocols and we always send binary frames, // We currently do not support any subprotocols and we always send binary frames,
// but for backwards compatibilty we need to reply the requested protocols // but for backwards compatibilty we need to reply the requested protocols
if let Some(ws_proto) = headers.get(SEC_WEBSOCKET_PROTOCOL) { if let Some(ws_proto) = headers.get(SEC_WEBSOCKET_PROTOCOL) {