From 0f1b84e93cea47135142bd0c9b0e7f67a7ab5638 Mon Sep 17 00:00:00 2001 From: Lukas Wagner Date: Wed, 29 Jan 2025 10:17:39 +0100 Subject: [PATCH] sys: fs: derive `Copy` for CreateOptions Pretty much all functions accepting `CreateOptions` take a value and not a reference, so I've found myself using `.clone()` quite often in code I've written recently. The struct is only 24 bytes large (verified by a `std::mem::size_of::()`), so it should be absolutely fine to just derive Copy for it. Signed-off-by: Lukas Wagner --- proxmox-sys/src/fs/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-sys/src/fs/mod.rs b/proxmox-sys/src/fs/mod.rs index 4dbc3ec9..752b75d2 100644 --- a/proxmox-sys/src/fs/mod.rs +++ b/proxmox-sys/src/fs/mod.rs @@ -30,7 +30,7 @@ pub fn fchown(fd: RawFd, owner: Option, group: Option) -> Result<(), E } /// Define permissions, owner and group when creating files/dirs -#[derive(Clone, Default)] +#[derive(Copy, Clone, Default)] pub struct CreateOptions { perm: Option, owner: Option,