From 5e778d983ab431258007b76ad5114d607c1ac890 Mon Sep 17 00:00:00 2001 From: Thomas Lamprecht Date: Sat, 5 Apr 2025 16:30:49 +0200 Subject: [PATCH] ui: datastore tuning options: increase width and rework labels This was getting cramped, and while it might be actually even nicer to got to more verbose style like we use for advanced settings of backup jobs in Proxmox VE, with actual sentences describing the options basic effects and rationale. But this is way quicker to do and adds already a bit more rationale, and we can always do more later on when there's less release time pressure. Signed-off-by: Thomas Lamprecht --- www/Utils.js | 4 ++-- www/datastore/OptionView.js | 23 ++++++++++++----------- 2 files changed, 14 insertions(+), 13 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index 50dd4d7e..1960abb3 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -851,12 +851,12 @@ Ext.define('PBS.Utils', { let gc_atime_safety_check = tuning['gc-atime-safety-check']; delete tuning['gc-atime-safety-check']; - options.push(`${gettext('GC Access Time Safety Check')}: ${gc_atime_safety_check ?? true}`); + options.push(`${gettext('GC Access-Time Support Check')}: ${gc_atime_safety_check ?? true}`); let gc_atime_cutoff = tuning['gc-atime-cutoff']; delete tuning['gc-atime-cutoff']; gc_atime_cutoff = gc_atime_cutoff ?? '1445'; - options.push(`${gettext('GC Access Time Cutoff')}: ${gc_atime_cutoff}m`); + options.push(`${gettext('GC Access-Time Cutoff')}: ${gc_atime_cutoff}m`); let gc_cache_capacity = tuning['gc-cache-capacity']; delete tuning['gc-cache-capacity']; diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js index c213e753..d74029f4 100644 --- a/www/datastore/OptionView.js +++ b/www/datastore/OptionView.js @@ -236,7 +236,7 @@ Ext.define('PBS.Datastore.Options', { xtype: 'proxmoxWindowEdit', title: gettext('Tuning Options'), onlineHelp: 'datastore_tuning_options', - width: 350, + width: 500, items: { xtype: 'inputpanel', onGetValues: function(values) { @@ -258,7 +258,8 @@ Ext.define('PBS.Datastore.Options', { { xtype: 'proxmoxKVComboBox', name: 'chunk-order', - fieldLabel: gettext('Chunk Order'), + fieldLabel: gettext('Chunk Iteration Order'), + labelWidth: 200, comboItems: Object.entries(PBS.Utils.tuningOptions['chunk-order']), deleteEmpty: true, value: '__default__', @@ -266,7 +267,8 @@ Ext.define('PBS.Datastore.Options', { { xtype: 'proxmoxKVComboBox', name: 'sync-level', - fieldLabel: gettext('Sync Level'), + fieldLabel: gettext('Data Sync Level'), + labelWidth: 200, comboItems: Object.entries(PBS.Utils.tuningOptions['sync-level']), deleteEmpty: true, value: '__default__', @@ -274,7 +276,8 @@ Ext.define('PBS.Datastore.Options', { { xtype: 'proxmoxcheckbox', name: 'gc-atime-safety-check', - fieldLabel: gettext('GC atime Check'), + fieldLabel: gettext('GC Access-Time Support Check'), + labelWidth: 200, autoEl: { tag: 'div', 'data-qtip': gettext('Ensure underlying storage honors access time updates'), @@ -287,19 +290,17 @@ Ext.define('PBS.Datastore.Options', { { xtype: 'proxmoxintegerfield', name: 'gc-atime-cutoff', + fieldLabel: gettext('GC Access-Time Cutoff (minutes)'), + labelWidth: 200, emptyText: gettext('1445 (24 hours 5 minutes)'), - fieldLabel: gettext('GC atime Cutoff'), - autoEl: { - tag: 'div', - 'data-qtip': gettext('Cutoff for atime in minutes'), - }, deleteEmpty: true, }, { xtype: 'proxmoxintegerfield', name: 'gc-cache-capacity', - fieldLabel: gettext('GC cache capacity'), - emptyText: Proxmox.Utils.defaultText, + fieldLabel: gettext('GC Cache Capacity (# chunks)'), + labelWidth: 200, + emptyText: gettext('1048576 (0 disables chache)'), minValue: 0, maxValue: 8 * 1024 * 1024, deleteEmpty: true,