Proxmox-Port/pixman
1
0
Fork 0
mirror of https://salsa.debian.org/xorg-team/lib/pixman synced 2025-09-04 00:13:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

stresstest: Ensure that the rasterizer is only given alpha formats

Browse Source 
In c2cb303d33, return_if_fail()s were added to
prevent the trapezoid rasterizers from being called with non-alpha
formats. However, stress-test actually does call the rasterizers with
non-alpha formats, but because _pixman_log_error() is disabled in
versions with an odd minor number, the errors never materialized.

Fix this by changing the argument to random format to an enum of three
values DONT_CARE, PREFER_ALPHA, or REQUIRE_ALPHA, and then in the
switch that calls the trapezoid rasterizers, pass the appropriate
value for the function in question.
This commit is contained in:
Søren Sandmann Pedersen 2013-01-29 20:23:31 -05:00
parent afde862928
commit 349015e1fc
1 changed files with 63 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
test/stress-test.c
View File

@ -205,13 +205,21 @@ rand_y (pixman_image_t *image)
return log_rand (); return log_rand ();
} }
typedef enum
{
DONT_CARE,
PREFER_ALPHA,
REQUIRE_ALPHA
} alpha_preference_t;
static pixman_format_code_t static pixman_format_code_t
random_format (pixman_bool_t prefer_alpha) random_format (alpha_preference_t alpha)
{ {
pixman_format_code_t format; pixman_format_code_t format;
int n = prng_rand_n (ARRAY_LENGTH (image_formats)); int n = prng_rand_n (ARRAY_LENGTH (image_formats));
if (prefer_alpha && prng_rand_n (4) != 0) if (alpha >= PREFER_ALPHA &&
(alpha == REQUIRE_ALPHA || prng_rand_n (4) != 0))
{ {
do do
{ {
@ -227,7 +235,7 @@ random_format (pixman_bool_t prefer_alpha)
} }
static pixman_image_t * static pixman_image_t *
create_random_bits_image (pixman_bool_t prefer_alpha) create_random_bits_image (alpha_preference_t alpha_preference)
{ {
pixman_format_code_t format; pixman_format_code_t format;
pixman_indexed_t *indexed; pixman_indexed_t *indexed;
@ -241,7 +249,7 @@ create_random_bits_image (pixman_bool_t prefer_alpha)
int n_coefficients = 0; int n_coefficients = 0;
/* format */ /* format */
format = random_format (prefer_alpha); format = random_format (alpha_preference);
indexed = NULL; indexed = NULL;
if (PIXMAN_FORMAT_TYPE (format) == PIXMAN_TYPE_COLOR) if (PIXMAN_FORMAT_TYPE (format) == PIXMAN_TYPE_COLOR)
@ -410,7 +418,7 @@ set_general_properties (pixman_image_t *image, pixman_bool_t allow_alpha_map)
pixman_image_t *alpha_map; pixman_image_t *alpha_map;
int16_t x, y; int16_t x, y;
alpha_map = create_random_bits_image (FALSE); alpha_map = create_random_bits_image (DONT_CARE);
if (alpha_map) if (alpha_map)
{ {
@ -716,7 +724,7 @@ create_random_image (void)
{ {
default: default:
case 0: case 0:
result = create_random_bits_image (FALSE); result = create_random_bits_image (DONT_CARE);
break; break;
case 1: case 1:
@ -855,27 +863,27 @@ run_test (uint32_t seed, pixman_bool_t verbose, uint32_t mod)
{ {
int n_traps; int n_traps;
pixman_trapezoid_t *trapezoids; pixman_trapezoid_t *trapezoids;
int p = prng_rand_n (3);
dest = create_random_bits_image (TRUE); if (p == 0)
dest = create_random_bits_image (DONT_CARE);
else
dest = create_random_bits_image (REQUIRE_ALPHA);
if (!dest)
goto out;
if (dest)
{
set_general_properties (dest, TRUE); set_general_properties (dest, TRUE);
trapezoids = create_random_trapezoids ( if (!(trapezoids = create_random_trapezoids (
&n_traps, dest->bits.width, dest->bits.height); &n_traps, dest->bits.width, dest->bits.height)))
if (trapezoids)
{ {
switch (prng_rand_n (3)) goto out;
}
switch (p)
{ {
case 0: case 0:
pixman_rasterize_trapezoid (
dest, &trapezoids[prng_rand_n (n_traps)],
rand_x (dest), rand_y (dest));
break;
case 1:
source = create_random_image (); source = create_random_image ();
if (source) if (source)
@ -884,13 +892,19 @@ run_test (uint32_t seed, pixman_bool_t verbose, uint32_t mod)
pixman_composite_trapezoids ( pixman_composite_trapezoids (
op, source, dest, op, source, dest,
random_format (TRUE), random_format (REQUIRE_ALPHA),
rand_x (source), rand_y (source), rand_x (source), rand_y (source),
rand_x (dest), rand_y (dest), rand_x (dest), rand_y (dest),
n_traps, trapezoids); n_traps, trapezoids);
} }
break; break;
case 1:
pixman_rasterize_trapezoid (
dest, &trapezoids[prng_rand_n (n_traps)],
rand_x (dest), rand_y (dest));
break;
case 2: case 2:
pixman_add_trapezoids ( pixman_add_trapezoids (
dest, rand_x (dest), rand_y (dest), n_traps, trapezoids); dest, rand_x (dest), rand_y (dest), n_traps, trapezoids);
@ -899,11 +913,9 @@ run_test (uint32_t seed, pixman_bool_t verbose, uint32_t mod)
free (trapezoids); free (trapezoids);
} }
}
}
else else
{ {
dest = create_random_bits_image (FALSE); dest = create_random_bits_image (DONT_CARE);
source = create_random_image (); source = create_random_image ();
mask = create_random_image (); mask = create_random_image ();
@ -923,6 +935,7 @@ run_test (uint32_t seed, pixman_bool_t verbose, uint32_t mod)
} }
} }
out:
if (source) if (source)
pixman_image_unref (source); pixman_image_unref (source);
if (mask) if (mask)