mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2025-08-16 05:12:23 +00:00
5ace19bd83
Add missing (GE)NL_SET_ERR_MSG_*() variants to the list of macros checked for strings ending with a newline. Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Signed-off-by: Gal Pressman <gal@nvidia.com> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Link: https://patch.msgid.link/20250226093904.6632-2-gal@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
79 lines
1.8 KiB
Plaintext
79 lines
1.8 KiB
Plaintext
// SPDX-License-Identifier: GPL-2.0-only
|
|
///
|
|
/// Catch strings ending in newline with (GE)NL_SET_ERR_MSG*.
|
|
///
|
|
// Confidence: Very High
|
|
// Copyright: (C) 2020 Intel Corporation
|
|
// URL: https://coccinelle.gitlabpages.inria.fr/website
|
|
// Options: --no-includes --include-headers
|
|
|
|
virtual context
|
|
virtual org
|
|
virtual report
|
|
|
|
@r depends on context || org || report@
|
|
expression e;
|
|
constant m;
|
|
position p;
|
|
@@
|
|
\(GENL_SET_ERR_MSG\|GENL_SET_ERR_MSG_FMT\|NL_SET_ERR_MSG\|NL_SET_ERR_MSG_MOD\|
|
|
NL_SET_ERR_MSG_FMT\|NL_SET_ERR_MSG_FMT_MOD\|NL_SET_ERR_MSG_WEAK\|
|
|
NL_SET_ERR_MSG_WEAK_MOD\|NL_SET_ERR_MSG_ATTR_POL\|
|
|
NL_SET_ERR_MSG_ATTR_POL_FMT\|NL_SET_ERR_MSG_ATTR\|
|
|
NL_SET_ERR_MSG_ATTR_FMT\)(e,m@p,...)
|
|
|
|
@script:python@
|
|
m << r.m;
|
|
@@
|
|
|
|
if not m.endswith("\\n\""):
|
|
cocci.include_match(False)
|
|
|
|
@r1 depends on r@
|
|
identifier fname;
|
|
expression r.e;
|
|
constant r.m;
|
|
position r.p;
|
|
@@
|
|
fname(e,m@p,...)
|
|
|
|
//----------------------------------------------------------
|
|
// For context mode
|
|
//----------------------------------------------------------
|
|
|
|
@depends on context && r@
|
|
identifier r1.fname;
|
|
expression r.e;
|
|
constant r.m;
|
|
@@
|
|
* fname(e,m,...)
|
|
|
|
//----------------------------------------------------------
|
|
// For org mode
|
|
//----------------------------------------------------------
|
|
|
|
@script:python depends on org@
|
|
fname << r1.fname;
|
|
m << r.m;
|
|
p << r.p;
|
|
@@
|
|
|
|
if m.endswith("\\n\""):
|
|
msg="WARNING avoid newline at end of message in %s" % (fname)
|
|
msg_safe=msg.replace("[","@(").replace("]",")")
|
|
coccilib.org.print_todo(p[0], msg_safe)
|
|
|
|
//----------------------------------------------------------
|
|
// For report mode
|
|
//----------------------------------------------------------
|
|
|
|
@script:python depends on report@
|
|
fname << r1.fname;
|
|
m << r.m;
|
|
p << r.p;
|
|
@@
|
|
|
|
if m.endswith("\\n\""):
|
|
msg="WARNING avoid newline at end of message in %s" % (fname)
|
|
coccilib.report.print_report(p[0], msg)
|