Joe Damato b4a8085cee e1000: Move cancel_work_sync to avoid deadlock ... Previously, e1000_down called cancel_work_sync for the e1000 reset task (via e1000_down_and_stop), which takes RTNL. As reported by users and syzbot, a deadlock is possible in the following scenario: CPU 0: - RTNL is held - e1000_close - e1000_down - cancel_work_sync (cancel / wait for e1000_reset_task()) CPU 1: - process_one_work - e1000_reset_task - take RTNL To remedy this, avoid calling cancel_work_sync from e1000_down (e1000_reset_task does nothing if the device is down anyway). Instead, call cancel_work_sync for e1000_reset_task when the device is being removed. Fixes: e400c7444d ("e1000: Hold RTNL when e1000_down can be called") Reported-by: syzbot+846bb38dc67fe62cc733@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/683837bf.a00a0220.52848.0003.GAE@google.com/ Reported-by: John <john.cs.hey@gmail.com> Closes: https://lore.kernel.org/netdev/CAP=Rh=OEsn4y_2LvkO3UtDWurKcGPnZ_NPSXK=FbgygNXL37Sw@mail.gmail.com/ Signed-off-by: Joe Damato <jdamato@fastly.com> Acked-by: Stanislav Fomichev <sdf@fomichev.me> Acked-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>		2025-06-10 09:10:47 -07:00
..
e1000_ethtool.c
e1000_hw.c	intel: legacy: field get conversion	2023-12-18 11:20:43 -08:00
e1000_hw.h	net: e1000: Remove unused declarations	2023-08-13 12:28:03 +01:00
e1000_main.c	e1000: Move cancel_work_sync to avoid deadlock	2025-06-10 09:10:47 -07:00
e1000_osdep.h
e1000_param.c
e1000.h	net: e1000: Remove unused declarations	2023-08-13 12:28:03 +01:00
Makefile	net: intel: Use *-y instead of *-objs in Makefile	2024-06-10 19:52:44 -07:00