Proxmox-Port/linux
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2025-09-04 15:20:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

drm/mediatek: Switch to for_each_child_of_node_scoped()

Browse Source 
Introduce the scoped variant of the loop to automatically release the
child node when it goes out of scope, which is more robust than the
non-scoped variant, and accounts for new early exits that could be added
in the future.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20241011-mtk_drm_drv_memleak-v1-2-2b40c74c8d75@gmail.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
This commit is contained in:
Javier Carrasco 2024-10-11 21:21:52 +02:00 committed by Chun-Kuang Hu
parent f708e8b4cf
commit fd620fc25d
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/gpu/drm/mediatek/mtk_drm_drv.c
View File

@ -372,12 +372,11 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev)
struct mtk_drm_private *temp_drm_priv; struct mtk_drm_private *temp_drm_priv;
struct device_node *phandle = dev->parent->of_node; struct device_node *phandle = dev->parent->of_node;
const struct of_device_id *of_id; const struct of_device_id *of_id;
struct device_node *node;
struct device *drm_dev; struct device *drm_dev;
unsigned int cnt = 0; unsigned int cnt = 0;
int i, j; int i, j;
for_each_child_of_node(phandle->parent, node) { for_each_child_of_node_scoped(phandle->parent, node) {
struct platform_device *pdev; struct platform_device *pdev;
of_id = of_match_node(mtk_drm_of_ids, node); of_id = of_match_node(mtk_drm_of_ids, node);
@ -406,10 +405,8 @@ static bool mtk_drm_get_all_drm_priv(struct device *dev)
if (temp_drm_priv->mtk_drm_bound) if (temp_drm_priv->mtk_drm_bound)
cnt++; cnt++;
if (cnt == MAX_CRTC) { if (cnt == MAX_CRTC)
of_node_put(node);
break; break;
}
} }
if (drm_priv->data->mmsys_dev_num == cnt) { if (drm_priv->data->mmsys_dev_num == cnt) {