mirror of
				https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
				synced 2025-10-31 09:36:25 +00:00 
			
		
		
		
	 30736a4d43
			
		
	
	
		30736a4d43
		
	
	
	
	
		
			
			Pass mm->flags as a coredump parameter for consistency.
 ---
1787         if (mm->core_state || !get_dumpable(mm)) {  <- (1)
1788                 up_write(&mm->mmap_sem);
1789                 put_cred(cred);
1790                 goto fail;
1791         }
1792
[...]
1798         if (get_dumpable(mm) == 2) {    /* Setuid core dump mode */ <-(2)
1799                 flag = O_EXCL;          /* Stop rewrite attacks */
1800                 cred->fsuid = 0;        /* Dump root private */
1801         }
 ---
Since dumpable bits are not protected by lock, there is a chance to change
these bits between (1) and (2).
To solve this issue, this patch copies mm->flags to
coredump_params.mm_flags at the beginning of do_coredump() and uses it
instead of get_dumpable() while dumping core.
This copy is also passed to binfmt->core_dump, since elf*_core_dump() uses
dump_filter bits in mm->flags.
[akpm@linux-foundation.org: fix merge]
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
	
			
		
			
				
	
	
		
			138 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			138 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| #ifndef _LINUX_BINFMTS_H
 | |
| #define _LINUX_BINFMTS_H
 | |
| 
 | |
| #include <linux/capability.h>
 | |
| 
 | |
| struct pt_regs;
 | |
| 
 | |
| /*
 | |
|  * These are the maximum length and maximum number of strings passed to the
 | |
|  * execve() system call.  MAX_ARG_STRLEN is essentially random but serves to
 | |
|  * prevent the kernel from being unduly impacted by misaddressed pointers.
 | |
|  * MAX_ARG_STRINGS is chosen to fit in a signed 32-bit integer.
 | |
|  */
 | |
| #define MAX_ARG_STRLEN (PAGE_SIZE * 32)
 | |
| #define MAX_ARG_STRINGS 0x7FFFFFFF
 | |
| 
 | |
| /* sizeof(linux_binprm->buf) */
 | |
| #define BINPRM_BUF_SIZE 128
 | |
| 
 | |
| #ifdef __KERNEL__
 | |
| #include <linux/list.h>
 | |
| 
 | |
| #define CORENAME_MAX_SIZE 128
 | |
| 
 | |
| /*
 | |
|  * This structure is used to hold the arguments that are used when loading binaries.
 | |
|  */
 | |
| struct linux_binprm{
 | |
| 	char buf[BINPRM_BUF_SIZE];
 | |
| #ifdef CONFIG_MMU
 | |
| 	struct vm_area_struct *vma;
 | |
| #else
 | |
| # define MAX_ARG_PAGES	32
 | |
| 	struct page *page[MAX_ARG_PAGES];
 | |
| #endif
 | |
| 	struct mm_struct *mm;
 | |
| 	unsigned long p; /* current top of mem */
 | |
| 	unsigned int
 | |
| 		cred_prepared:1,/* true if creds already prepared (multiple
 | |
| 				 * preps happen for interpreters) */
 | |
| 		cap_effective:1;/* true if has elevated effective capabilities,
 | |
| 				 * false if not; except for init which inherits
 | |
| 				 * its parent's caps anyway */
 | |
| #ifdef __alpha__
 | |
| 	unsigned int taso:1;
 | |
| #endif
 | |
| 	unsigned int recursion_depth;
 | |
| 	struct file * file;
 | |
| 	struct cred *cred;	/* new credentials */
 | |
| 	int unsafe;		/* how unsafe this exec is (mask of LSM_UNSAFE_*) */
 | |
| 	unsigned int per_clear;	/* bits to clear in current->personality */
 | |
| 	int argc, envc;
 | |
| 	char * filename;	/* Name of binary as seen by procps */
 | |
| 	char * interp;		/* Name of the binary really executed. Most
 | |
| 				   of the time same as filename, but could be
 | |
| 				   different for binfmt_{misc,script} */
 | |
| 	unsigned interp_flags;
 | |
| 	unsigned interp_data;
 | |
| 	unsigned long loader, exec;
 | |
| };
 | |
| 
 | |
| #define BINPRM_FLAGS_ENFORCE_NONDUMP_BIT 0
 | |
| #define BINPRM_FLAGS_ENFORCE_NONDUMP (1 << BINPRM_FLAGS_ENFORCE_NONDUMP_BIT)
 | |
| 
 | |
| /* fd of the binary should be passed to the interpreter */
 | |
| #define BINPRM_FLAGS_EXECFD_BIT 1
 | |
| #define BINPRM_FLAGS_EXECFD (1 << BINPRM_FLAGS_EXECFD_BIT)
 | |
| 
 | |
| #define BINPRM_MAX_RECURSION 4
 | |
| 
 | |
| /* Function parameter for binfmt->coredump */
 | |
| struct coredump_params {
 | |
| 	long signr;
 | |
| 	struct pt_regs *regs;
 | |
| 	struct file *file;
 | |
| 	unsigned long limit;
 | |
| 	unsigned long mm_flags;
 | |
| };
 | |
| 
 | |
| /*
 | |
|  * This structure defines the functions that are used to load the binary formats that
 | |
|  * linux accepts.
 | |
|  */
 | |
| struct linux_binfmt {
 | |
| 	struct list_head lh;
 | |
| 	struct module *module;
 | |
| 	int (*load_binary)(struct linux_binprm *, struct  pt_regs * regs);
 | |
| 	int (*load_shlib)(struct file *);
 | |
| 	int (*core_dump)(struct coredump_params *cprm);
 | |
| 	unsigned long min_coredump;	/* minimal dump size */
 | |
| 	int hasvdso;
 | |
| };
 | |
| 
 | |
| extern int __register_binfmt(struct linux_binfmt *fmt, int insert);
 | |
| 
 | |
| /* Registration of default binfmt handlers */
 | |
| static inline int register_binfmt(struct linux_binfmt *fmt)
 | |
| {
 | |
| 	return __register_binfmt(fmt, 0);
 | |
| }
 | |
| /* Same as above, but adds a new binfmt at the top of the list */
 | |
| static inline int insert_binfmt(struct linux_binfmt *fmt)
 | |
| {
 | |
| 	return __register_binfmt(fmt, 1);
 | |
| }
 | |
| 
 | |
| extern void unregister_binfmt(struct linux_binfmt *);
 | |
| 
 | |
| extern int prepare_binprm(struct linux_binprm *);
 | |
| extern int __must_check remove_arg_zero(struct linux_binprm *);
 | |
| extern int search_binary_handler(struct linux_binprm *,struct pt_regs *);
 | |
| extern int flush_old_exec(struct linux_binprm * bprm);
 | |
| extern void setup_new_exec(struct linux_binprm * bprm);
 | |
| 
 | |
| extern int suid_dumpable;
 | |
| #define SUID_DUMP_DISABLE	0	/* No setuid dumping */
 | |
| #define SUID_DUMP_USER		1	/* Dump as user of process */
 | |
| #define SUID_DUMP_ROOT		2	/* Dump as root */
 | |
| 
 | |
| /* Stack area protections */
 | |
| #define EXSTACK_DEFAULT   0	/* Whatever the arch defaults to */
 | |
| #define EXSTACK_DISABLE_X 1	/* Disable executable stacks */
 | |
| #define EXSTACK_ENABLE_X  2	/* Enable executable stacks */
 | |
| 
 | |
| extern int setup_arg_pages(struct linux_binprm * bprm,
 | |
| 			   unsigned long stack_top,
 | |
| 			   int executable_stack);
 | |
| extern int bprm_mm_init(struct linux_binprm *bprm);
 | |
| extern int copy_strings_kernel(int argc,char ** argv,struct linux_binprm *bprm);
 | |
| extern int prepare_bprm_creds(struct linux_binprm *bprm);
 | |
| extern void install_exec_creds(struct linux_binprm *bprm);
 | |
| extern void do_coredump(long signr, int exit_code, struct pt_regs *regs);
 | |
| extern void set_binfmt(struct linux_binfmt *new);
 | |
| extern void free_bprm(struct linux_binprm *);
 | |
| 
 | |
| #endif /* __KERNEL__ */
 | |
| #endif /* _LINUX_BINFMTS_H */
 |