mirror of
				https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
				synced 2025-10-31 20:42:39 +00:00 
			
		
		
		
	 597781f3e5
			
		
	
	
		597781f3e5
		
	
	
	
	
		
			
			kunmap_atomic() is currently at level -4 on Rusty's "Hard To Misuse"
list[1] ("Follow common convention and you'll get it wrong"), except in
some architectures when CONFIG_DEBUG_HIGHMEM is set[2][3].
kunmap() takes a pointer to a struct page; kunmap_atomic(), however, takes
takes a pointer to within the page itself.  This seems to once in a while
trip people up (the convention they are following is the one from
kunmap()).
Make it much harder to misuse, by moving it to level 9 on Rusty's list[4]
("The compiler/linker won't let you get it wrong").  This is done by
refusing to build if the type of its first argument is a pointer to a
struct page.
The real kunmap_atomic() is renamed to kunmap_atomic_notypecheck()
(which is what you would call in case for some strange reason calling it
with a pointer to a struct page is not incorrect in your code).
The previous version of this patch was compile tested on x86-64.
[1] http://ozlabs.org/~rusty/index.cgi/tech/2008-04-01.html
[2] In these cases, it is at level 5, "Do it right or it will always
    break at runtime."
[3] At least mips and powerpc look very similar, and sparc also seems to
    share a common ancestor with both; there seems to be quite some
    degree of copy-and-paste coding here. The include/asm/highmem.h file
    for these three archs mention x86 CPUs at its top.
[4] http://ozlabs.org/~rusty/index.cgi/tech/2008-03-30.html
[5] As an aside, could someone tell me why mn10300 uses unsigned long as
    the first parameter of kunmap_atomic() instead of void *?
Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Cc: Russell King <linux@arm.linux.org.uk> (arch/arm)
Cc: Ralf Baechle <ralf@linux-mips.org> (arch/mips)
Cc: David Howells <dhowells@redhat.com> (arch/frv, arch/mn10300)
Cc: Koichi Yasutake <yasutake.koichi@jp.panasonic.com> (arch/mn10300)
Cc: Kyle McMartin <kyle@mcmartin.ca> (arch/parisc)
Cc: Helge Deller <deller@gmx.de> (arch/parisc)
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org> (arch/parisc)
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> (arch/powerpc)
Cc: Paul Mackerras <paulus@samba.org> (arch/powerpc)
Cc: "David S. Miller" <davem@davemloft.net> (arch/sparc)
Cc: Thomas Gleixner <tglx@linutronix.de> (arch/x86)
Cc: Ingo Molnar <mingo@redhat.com> (arch/x86)
Cc: "H. Peter Anvin" <hpa@zytor.com> (arch/x86)
Cc: Arnd Bergmann <arnd@arndb.de> (include/asm-generic)
Cc: Rusty Russell <rusty@rustcorp.com.au> ("Hard To Misuse" list)
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
	
			
		
			
				
	
	
		
			132 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			132 lines
		
	
	
		
			3.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| #include <linux/highmem.h>
 | |
| #include <linux/module.h>
 | |
| #include <linux/swap.h> /* for totalram_pages */
 | |
| 
 | |
| void *kmap(struct page *page)
 | |
| {
 | |
| 	might_sleep();
 | |
| 	if (!PageHighMem(page))
 | |
| 		return page_address(page);
 | |
| 	return kmap_high(page);
 | |
| }
 | |
| 
 | |
| void kunmap(struct page *page)
 | |
| {
 | |
| 	if (in_interrupt())
 | |
| 		BUG();
 | |
| 	if (!PageHighMem(page))
 | |
| 		return;
 | |
| 	kunmap_high(page);
 | |
| }
 | |
| 
 | |
| /*
 | |
|  * kmap_atomic/kunmap_atomic is significantly faster than kmap/kunmap because
 | |
|  * no global lock is needed and because the kmap code must perform a global TLB
 | |
|  * invalidation when the kmap pool wraps.
 | |
|  *
 | |
|  * However when holding an atomic kmap it is not legal to sleep, so atomic
 | |
|  * kmaps are appropriate for short, tight code paths only.
 | |
|  */
 | |
| void *kmap_atomic_prot(struct page *page, enum km_type type, pgprot_t prot)
 | |
| {
 | |
| 	enum fixed_addresses idx;
 | |
| 	unsigned long vaddr;
 | |
| 
 | |
| 	/* even !CONFIG_PREEMPT needs this, for in_atomic in do_page_fault */
 | |
| 	pagefault_disable();
 | |
| 
 | |
| 	if (!PageHighMem(page))
 | |
| 		return page_address(page);
 | |
| 
 | |
| 	debug_kmap_atomic(type);
 | |
| 
 | |
| 	idx = type + KM_TYPE_NR*smp_processor_id();
 | |
| 	vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx);
 | |
| 	BUG_ON(!pte_none(*(kmap_pte-idx)));
 | |
| 	set_pte(kmap_pte-idx, mk_pte(page, prot));
 | |
| 
 | |
| 	return (void *)vaddr;
 | |
| }
 | |
| 
 | |
| void *kmap_atomic(struct page *page, enum km_type type)
 | |
| {
 | |
| 	return kmap_atomic_prot(page, type, kmap_prot);
 | |
| }
 | |
| 
 | |
| void kunmap_atomic_notypecheck(void *kvaddr, enum km_type type)
 | |
| {
 | |
| 	unsigned long vaddr = (unsigned long) kvaddr & PAGE_MASK;
 | |
| 	enum fixed_addresses idx = type + KM_TYPE_NR*smp_processor_id();
 | |
| 
 | |
| 	/*
 | |
| 	 * Force other mappings to Oops if they'll try to access this pte
 | |
| 	 * without first remap it.  Keeping stale mappings around is a bad idea
 | |
| 	 * also, in case the page changes cacheability attributes or becomes
 | |
| 	 * a protected page in a hypervisor.
 | |
| 	 */
 | |
| 	if (vaddr == __fix_to_virt(FIX_KMAP_BEGIN+idx))
 | |
| 		kpte_clear_flush(kmap_pte-idx, vaddr);
 | |
| 	else {
 | |
| #ifdef CONFIG_DEBUG_HIGHMEM
 | |
| 		BUG_ON(vaddr < PAGE_OFFSET);
 | |
| 		BUG_ON(vaddr >= (unsigned long)high_memory);
 | |
| #endif
 | |
| 	}
 | |
| 
 | |
| 	pagefault_enable();
 | |
| }
 | |
| 
 | |
| /*
 | |
|  * This is the same as kmap_atomic() but can map memory that doesn't
 | |
|  * have a struct page associated with it.
 | |
|  */
 | |
| void *kmap_atomic_pfn(unsigned long pfn, enum km_type type)
 | |
| {
 | |
| 	return kmap_atomic_prot_pfn(pfn, type, kmap_prot);
 | |
| }
 | |
| EXPORT_SYMBOL_GPL(kmap_atomic_pfn); /* temporarily in use by i915 GEM until vmap */
 | |
| 
 | |
| struct page *kmap_atomic_to_page(void *ptr)
 | |
| {
 | |
| 	unsigned long idx, vaddr = (unsigned long)ptr;
 | |
| 	pte_t *pte;
 | |
| 
 | |
| 	if (vaddr < FIXADDR_START)
 | |
| 		return virt_to_page(ptr);
 | |
| 
 | |
| 	idx = virt_to_fix(vaddr);
 | |
| 	pte = kmap_pte - (idx - FIX_KMAP_BEGIN);
 | |
| 	return pte_page(*pte);
 | |
| }
 | |
| 
 | |
| EXPORT_SYMBOL(kmap);
 | |
| EXPORT_SYMBOL(kunmap);
 | |
| EXPORT_SYMBOL(kmap_atomic);
 | |
| EXPORT_SYMBOL(kunmap_atomic_notypecheck);
 | |
| EXPORT_SYMBOL(kmap_atomic_prot);
 | |
| EXPORT_SYMBOL(kmap_atomic_to_page);
 | |
| 
 | |
| void __init set_highmem_pages_init(void)
 | |
| {
 | |
| 	struct zone *zone;
 | |
| 	int nid;
 | |
| 
 | |
| 	for_each_zone(zone) {
 | |
| 		unsigned long zone_start_pfn, zone_end_pfn;
 | |
| 
 | |
| 		if (!is_highmem(zone))
 | |
| 			continue;
 | |
| 
 | |
| 		zone_start_pfn = zone->zone_start_pfn;
 | |
| 		zone_end_pfn = zone_start_pfn + zone->spanned_pages;
 | |
| 
 | |
| 		nid = zone_to_nid(zone);
 | |
| 		printk(KERN_INFO "Initializing %s for node %d (%08lx:%08lx)\n",
 | |
| 				zone->name, nid, zone_start_pfn, zone_end_pfn);
 | |
| 
 | |
| 		add_highpages_with_active_regions(nid, zone_start_pfn,
 | |
| 				 zone_end_pfn);
 | |
| 	}
 | |
| 	totalram_pages += totalhigh_pages;
 | |
| }
 |