mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
synced 2025-08-27 15:36:48 +00:00
c195b9c6ab
The intel-lpmd tool [1], which uses the THERMAL_GENL_ATTR_CPU_CAPABILITY attribute to receive HFI events from kernel space, encounters a segmentation fault after commit1773572863("thermal: netlink: Add the commands and the events for the thresholds"). The issue arises because the THERMAL_GENL_ATTR_CPU_CAPABILITY raw value was changed while intel_lpmd still uses the old value. Although intel_lpmd can be updated to check the THERMAL_GENL_VERSION and use the appropriate THERMAL_GENL_ATTR_CPU_CAPABILITY value, the commit itself is questionable. The commit introduced a new element in the middle of enum thermal_genl_attr, which affects many existing attributes and introduces potential risks and unnecessary maintenance burdens for userspace thermal netlink event users. Solve the issue by moving the newly introduced THERMAL_GENL_ATTR_TZ_PREV_TEMP attribute to the end of the enum thermal_genl_attr. This ensures that all existing thermal generic netlink attributes remain unaffected. Link: https://github.com/intel/intel-lpmd [1] Fixes:1773572863("thermal: netlink: Add the commands and the events for the thresholds") Signed-off-by: Zhang Rui <rui.zhang@intel.com> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://patch.msgid.link/20250208074907.5679-1-rui.zhang@intel.com [ rjw: Subject edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
111 lines
4.1 KiB
C
111 lines
4.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
|
|
#ifndef _UAPI_LINUX_THERMAL_H
|
|
#define _UAPI_LINUX_THERMAL_H
|
|
|
|
#define THERMAL_NAME_LENGTH 20
|
|
#define THERMAL_THRESHOLD_WAY_UP 0x1
|
|
#define THERMAL_THRESHOLD_WAY_DOWN 0x2
|
|
|
|
enum thermal_device_mode {
|
|
THERMAL_DEVICE_DISABLED = 0,
|
|
THERMAL_DEVICE_ENABLED,
|
|
};
|
|
|
|
enum thermal_trip_type {
|
|
THERMAL_TRIP_ACTIVE = 0,
|
|
THERMAL_TRIP_PASSIVE,
|
|
THERMAL_TRIP_HOT,
|
|
THERMAL_TRIP_CRITICAL,
|
|
};
|
|
|
|
/* Adding event notification support elements */
|
|
#define THERMAL_GENL_FAMILY_NAME "thermal"
|
|
#define THERMAL_GENL_VERSION 0x02
|
|
#define THERMAL_GENL_SAMPLING_GROUP_NAME "sampling"
|
|
#define THERMAL_GENL_EVENT_GROUP_NAME "event"
|
|
|
|
/* Attributes of thermal_genl_family */
|
|
enum thermal_genl_attr {
|
|
THERMAL_GENL_ATTR_UNSPEC,
|
|
THERMAL_GENL_ATTR_TZ,
|
|
THERMAL_GENL_ATTR_TZ_ID,
|
|
THERMAL_GENL_ATTR_TZ_TEMP,
|
|
THERMAL_GENL_ATTR_TZ_TRIP,
|
|
THERMAL_GENL_ATTR_TZ_TRIP_ID,
|
|
THERMAL_GENL_ATTR_TZ_TRIP_TYPE,
|
|
THERMAL_GENL_ATTR_TZ_TRIP_TEMP,
|
|
THERMAL_GENL_ATTR_TZ_TRIP_HYST,
|
|
THERMAL_GENL_ATTR_TZ_MODE,
|
|
THERMAL_GENL_ATTR_TZ_NAME,
|
|
THERMAL_GENL_ATTR_TZ_CDEV_WEIGHT,
|
|
THERMAL_GENL_ATTR_TZ_GOV,
|
|
THERMAL_GENL_ATTR_TZ_GOV_NAME,
|
|
THERMAL_GENL_ATTR_CDEV,
|
|
THERMAL_GENL_ATTR_CDEV_ID,
|
|
THERMAL_GENL_ATTR_CDEV_CUR_STATE,
|
|
THERMAL_GENL_ATTR_CDEV_MAX_STATE,
|
|
THERMAL_GENL_ATTR_CDEV_NAME,
|
|
THERMAL_GENL_ATTR_GOV_NAME,
|
|
THERMAL_GENL_ATTR_CPU_CAPABILITY,
|
|
THERMAL_GENL_ATTR_CPU_CAPABILITY_ID,
|
|
THERMAL_GENL_ATTR_CPU_CAPABILITY_PERFORMANCE,
|
|
THERMAL_GENL_ATTR_CPU_CAPABILITY_EFFICIENCY,
|
|
THERMAL_GENL_ATTR_THRESHOLD,
|
|
THERMAL_GENL_ATTR_THRESHOLD_TEMP,
|
|
THERMAL_GENL_ATTR_THRESHOLD_DIRECTION,
|
|
THERMAL_GENL_ATTR_TZ_PREV_TEMP,
|
|
__THERMAL_GENL_ATTR_MAX,
|
|
};
|
|
#define THERMAL_GENL_ATTR_MAX (__THERMAL_GENL_ATTR_MAX - 1)
|
|
|
|
enum thermal_genl_sampling {
|
|
THERMAL_GENL_SAMPLING_TEMP,
|
|
__THERMAL_GENL_SAMPLING_MAX,
|
|
};
|
|
#define THERMAL_GENL_SAMPLING_MAX (__THERMAL_GENL_SAMPLING_MAX - 1)
|
|
|
|
/* Events of thermal_genl_family */
|
|
enum thermal_genl_event {
|
|
THERMAL_GENL_EVENT_UNSPEC,
|
|
THERMAL_GENL_EVENT_TZ_CREATE, /* Thermal zone creation */
|
|
THERMAL_GENL_EVENT_TZ_DELETE, /* Thermal zone deletion */
|
|
THERMAL_GENL_EVENT_TZ_DISABLE, /* Thermal zone disabled */
|
|
THERMAL_GENL_EVENT_TZ_ENABLE, /* Thermal zone enabled */
|
|
THERMAL_GENL_EVENT_TZ_TRIP_UP, /* Trip point crossed the way up */
|
|
THERMAL_GENL_EVENT_TZ_TRIP_DOWN, /* Trip point crossed the way down */
|
|
THERMAL_GENL_EVENT_TZ_TRIP_CHANGE, /* Trip point changed */
|
|
THERMAL_GENL_EVENT_TZ_TRIP_ADD, /* Trip point added */
|
|
THERMAL_GENL_EVENT_TZ_TRIP_DELETE, /* Trip point deleted */
|
|
THERMAL_GENL_EVENT_CDEV_ADD, /* Cdev bound to the thermal zone */
|
|
THERMAL_GENL_EVENT_CDEV_DELETE, /* Cdev unbound */
|
|
THERMAL_GENL_EVENT_CDEV_STATE_UPDATE, /* Cdev state updated */
|
|
THERMAL_GENL_EVENT_TZ_GOV_CHANGE, /* Governor policy changed */
|
|
THERMAL_GENL_EVENT_CPU_CAPABILITY_CHANGE, /* CPU capability changed */
|
|
THERMAL_GENL_EVENT_THRESHOLD_ADD, /* A thresold has been added */
|
|
THERMAL_GENL_EVENT_THRESHOLD_DELETE, /* A thresold has been deleted */
|
|
THERMAL_GENL_EVENT_THRESHOLD_FLUSH, /* All thresolds have been deleted */
|
|
THERMAL_GENL_EVENT_THRESHOLD_UP, /* A thresold has been crossed the way up */
|
|
THERMAL_GENL_EVENT_THRESHOLD_DOWN, /* A thresold has been crossed the way down */
|
|
__THERMAL_GENL_EVENT_MAX,
|
|
};
|
|
#define THERMAL_GENL_EVENT_MAX (__THERMAL_GENL_EVENT_MAX - 1)
|
|
|
|
/* Commands supported by the thermal_genl_family */
|
|
enum thermal_genl_cmd {
|
|
THERMAL_GENL_CMD_UNSPEC,
|
|
THERMAL_GENL_CMD_TZ_GET_ID, /* List of thermal zones id */
|
|
THERMAL_GENL_CMD_TZ_GET_TRIP, /* List of thermal trips */
|
|
THERMAL_GENL_CMD_TZ_GET_TEMP, /* Get the thermal zone temperature */
|
|
THERMAL_GENL_CMD_TZ_GET_GOV, /* Get the thermal zone governor */
|
|
THERMAL_GENL_CMD_TZ_GET_MODE, /* Get the thermal zone mode */
|
|
THERMAL_GENL_CMD_CDEV_GET, /* List of cdev id */
|
|
THERMAL_GENL_CMD_THRESHOLD_GET, /* List of thresholds */
|
|
THERMAL_GENL_CMD_THRESHOLD_ADD, /* Add a threshold */
|
|
THERMAL_GENL_CMD_THRESHOLD_DELETE, /* Delete a threshold */
|
|
THERMAL_GENL_CMD_THRESHOLD_FLUSH, /* Flush all the thresholds */
|
|
__THERMAL_GENL_CMD_MAX,
|
|
};
|
|
#define THERMAL_GENL_CMD_MAX (__THERMAL_GENL_CMD_MAX - 1)
|
|
|
|
#endif /* _UAPI_LINUX_THERMAL_H */
|