mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
synced 2025-09-02 16:44:59 +00:00
0d423c4a78
1. Following the ARM SMC32 calling convention, the return value from secure monitor is a 32-bit signed integer. This patch changes the type of the return value of the function meson_sm_call(). 2. Now, when meson_sm_call() returns a 32-bit signed integer, we need to ensure that this value is not negative. It is important to check that the return value is not negative in both the meson_sm_call_read() and meson_sm_call_write() functions. 3. Add a comment explaining why it is necessary to check if the SMC return value is equal to 0 in the function meson_sm_call_read(). It is not obvious when reading this code. Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20230830140850.17130-1-avromanov@salutedevices.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
32 lines
923 B
C
32 lines
923 B
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (C) 2016 Endless Mobile, Inc.
|
|
* Author: Carlo Caione <carlo@endlessm.com>
|
|
*/
|
|
|
|
#ifndef _MESON_SM_FW_H_
|
|
#define _MESON_SM_FW_H_
|
|
|
|
enum {
|
|
SM_EFUSE_READ,
|
|
SM_EFUSE_WRITE,
|
|
SM_EFUSE_USER_MAX,
|
|
SM_GET_CHIP_ID,
|
|
SM_A1_PWRC_SET,
|
|
SM_A1_PWRC_GET,
|
|
};
|
|
|
|
struct meson_sm_firmware;
|
|
|
|
int meson_sm_call(struct meson_sm_firmware *fw, unsigned int cmd_index,
|
|
s32 *ret, u32 arg0, u32 arg1, u32 arg2, u32 arg3, u32 arg4);
|
|
int meson_sm_call_write(struct meson_sm_firmware *fw, void *buffer,
|
|
unsigned int b_size, unsigned int cmd_index, u32 arg0,
|
|
u32 arg1, u32 arg2, u32 arg3, u32 arg4);
|
|
int meson_sm_call_read(struct meson_sm_firmware *fw, void *buffer,
|
|
unsigned int bsize, unsigned int cmd_index, u32 arg0,
|
|
u32 arg1, u32 arg2, u32 arg3, u32 arg4);
|
|
struct meson_sm_firmware *meson_sm_get(struct device_node *firmware_node);
|
|
|
|
#endif /* _MESON_SM_FW_H_ */
|