mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
synced 2025-08-30 21:52:21 +00:00
d26a9f4f0a
The Dell SMBIOS driver uses the "id" field inside struct device for
prioritizing the WMI backend over the SMM backend. Because of this
the WMI backend modifies the "id" field of the underlying WMI device.
However the WMI core itself uses wdev->dev.id internally to track
device IDs, so modifying this value will result in a resource leak.
Fix this by not using the "id" field inside struct device for SMBIOS
prioritization. Instead extend struct smbios_device with a separate
"priority" field.
Tested on a Dell Inspiron 3505.
Fixes: 73f0f2b52c ("platform/x86: wmi: Fix WMI device naming issue")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20250722183841.9552-1-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
117 lines
3.2 KiB
C
117 lines
3.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Common functions for kernel modules using Dell SMBIOS
|
|
*
|
|
* Copyright (c) Red Hat <mjg@redhat.com>
|
|
* Copyright (c) 2014 Gabriele Mazzotta <gabriele.mzt@gmail.com>
|
|
* Copyright (c) 2014 Pali Rohár <pali@kernel.org>
|
|
*
|
|
* Based on documentation in the libsmbios package:
|
|
* Copyright (C) 2005-2014 Dell Inc.
|
|
*/
|
|
|
|
#ifndef _DELL_SMBIOS_H_
|
|
#define _DELL_SMBIOS_H_
|
|
|
|
#include <linux/device.h>
|
|
#include <uapi/linux/wmi.h>
|
|
|
|
/* Classes and selects used only in kernel drivers */
|
|
#define CLASS_KBD_BACKLIGHT 4
|
|
#define SELECT_KBD_BACKLIGHT 11
|
|
#define SELECT_THERMAL_MANAGEMENT 19
|
|
|
|
/* Tokens used in kernel drivers, any of these
|
|
* should be filtered from userspace access
|
|
*/
|
|
#define BRIGHTNESS_TOKEN 0x007d
|
|
#define KBD_LED_AC_TOKEN 0x0451
|
|
#define KBD_LED_OFF_TOKEN 0x01E1
|
|
#define KBD_LED_ON_TOKEN 0x01E2
|
|
#define KBD_LED_AUTO_TOKEN 0x01E3
|
|
#define KBD_LED_AUTO_25_TOKEN 0x02EA
|
|
#define KBD_LED_AUTO_50_TOKEN 0x02EB
|
|
#define KBD_LED_AUTO_75_TOKEN 0x02EC
|
|
#define KBD_LED_AUTO_100_TOKEN 0x02F6
|
|
#define BAT_PRI_AC_MODE_TOKEN 0x0341
|
|
#define BAT_ADAPTIVE_MODE_TOKEN 0x0342
|
|
#define BAT_CUSTOM_MODE_TOKEN 0x0343
|
|
#define BAT_STANDARD_MODE_TOKEN 0x0346
|
|
#define BAT_EXPRESS_MODE_TOKEN 0x0347
|
|
#define BAT_CUSTOM_CHARGE_START 0x0349
|
|
#define BAT_CUSTOM_CHARGE_END 0x034A
|
|
#define GLOBAL_MIC_MUTE_ENABLE 0x0364
|
|
#define GLOBAL_MIC_MUTE_DISABLE 0x0365
|
|
#define GLOBAL_MUTE_ENABLE 0x058C
|
|
#define GLOBAL_MUTE_DISABLE 0x058D
|
|
|
|
struct notifier_block;
|
|
|
|
struct calling_interface_token {
|
|
u16 tokenID;
|
|
u16 location;
|
|
union {
|
|
u16 value;
|
|
u16 stringlength;
|
|
};
|
|
};
|
|
|
|
struct calling_interface_structure {
|
|
struct dmi_header header;
|
|
u16 cmdIOAddress;
|
|
u8 cmdIOCode;
|
|
u32 supportedCmds;
|
|
struct calling_interface_token tokens[];
|
|
} __packed;
|
|
|
|
int dell_smbios_register_device(struct device *d, int priority, void *call_fn);
|
|
void dell_smbios_unregister_device(struct device *d);
|
|
|
|
int dell_smbios_error(int value);
|
|
int dell_smbios_call_filter(struct device *d,
|
|
struct calling_interface_buffer *buffer);
|
|
int dell_smbios_call(struct calling_interface_buffer *buffer);
|
|
|
|
void dell_fill_request(struct calling_interface_buffer *buffer,
|
|
u32 arg0, u32 arg1, u32 arg2, u32 arg3);
|
|
int dell_send_request(struct calling_interface_buffer *buffer,
|
|
u16 class, u16 select);
|
|
|
|
struct calling_interface_token *dell_smbios_find_token(int tokenid);
|
|
|
|
enum dell_laptop_notifier_actions {
|
|
DELL_LAPTOP_KBD_BACKLIGHT_BRIGHTNESS_CHANGED,
|
|
};
|
|
|
|
int dell_laptop_register_notifier(struct notifier_block *nb);
|
|
int dell_laptop_unregister_notifier(struct notifier_block *nb);
|
|
void dell_laptop_call_notifier(unsigned long action, void *data);
|
|
bool dell_smbios_class_is_supported(u16 class);
|
|
|
|
/* for the supported backends */
|
|
#ifdef CONFIG_DELL_SMBIOS_WMI
|
|
int init_dell_smbios_wmi(void);
|
|
void exit_dell_smbios_wmi(void);
|
|
#else /* CONFIG_DELL_SMBIOS_WMI */
|
|
static inline int init_dell_smbios_wmi(void)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline void exit_dell_smbios_wmi(void)
|
|
{}
|
|
#endif /* CONFIG_DELL_SMBIOS_WMI */
|
|
|
|
#ifdef CONFIG_DELL_SMBIOS_SMM
|
|
int init_dell_smbios_smm(void);
|
|
void exit_dell_smbios_smm(void);
|
|
#else /* CONFIG_DELL_SMBIOS_SMM */
|
|
static inline int init_dell_smbios_smm(void)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline void exit_dell_smbios_smm(void)
|
|
{}
|
|
#endif /* CONFIG_DELL_SMBIOS_SMM */
|
|
|
|
#endif /* _DELL_SMBIOS_H_ */
|