Gerhard Engleder b3ca9eef66 tsnep: fix timestamping with a stacked DSA driver ... This driver is susceptible to a form of the bug explained in commit c26a2c2ddc ("gianfar: Fix TX timestamping with a stacked DSA driver") and in Documentation/networking/timestamping.rst section "Other caveats for MAC drivers", specifically it timestamps any skb which has SKBTX_HW_TSTAMP, and does not consider if timestamping has been enabled in adapter->hwtstamp_config.tx_type. Evaluate the proper TX timestamping condition only once on the TX path (in tsnep_xmit_frame_ring()) and store the result in an additional TX entry flag. Evaluate the new TX entry flag in the TX confirmation path (in tsnep_tx_poll()). This way SKBTX_IN_PROGRESS is set by the driver as required, but never evaluated. SKBTX_IN_PROGRESS shall not be evaluated as it can be set by a stacked DSA driver and evaluating it would lead to unwanted timestamps. Fixes: 403f69bbdb ("tsnep: Add TSN endpoint Ethernet MAC driver") Suggested-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://patch.msgid.link/20250514195657.25874-1-gerhard@engleder-embedded.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2025-05-15 07:58:18 -07:00
..
Kconfig	tsnep: Use page pool for RX	2022-09-30 11:32:27 +01:00
Makefile	tsnep: Support XDP BPF program setup	2023-01-18 13:17:06 +00:00
tsnep_ethtool.c	tsnep: Remove setting of RX software timestamp	2024-09-03 15:17:48 -07:00
tsnep_hw.h	tsnep: Inline small fragments within TX descriptor	2023-10-16 09:59:34 +01:00
tsnep_main.c	tsnep: fix timestamping with a stacked DSA driver	2025-05-15 07:58:18 -07:00
tsnep_ptp.c	tsnep: Add free running cycle counter support	2022-05-10 09:48:09 +02:00
tsnep_rxnfc.c	tsnep: Add EtherType RX flow classification support	2022-09-30 11:32:27 +01:00
tsnep_selftests.c	net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum	2023-05-31 10:00:30 +01:00
tsnep_tc.c	net/sched: taprio: replace tc_taprio_qopt_offload :: enable with a "cmd" enum	2023-05-31 10:00:30 +01:00
tsnep_xdp.c	tsnep: Add XDP socket zero-copy RX support	2023-04-24 18:22:38 -07:00
tsnep.h	tsnep: Fix tsnep_request_irq() format-overflow warning	2023-10-24 13:05:28 -07:00