mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
synced 2025-08-27 15:36:48 +00:00

In drivers/hid/, most drivers depend on CONFIG_HID, while a couple of the
drivers in subdirectories instead depend on CONFIG_HID_SUPPORT and use
'select HID'. With the newly added INTEL_THC_HID, this causes a build
warning for a circular dependency:
WARNING: unmet direct dependencies detected for HID
Depends on [m]: HID_SUPPORT [=y] && INPUT [=m]
Selected by [y]:
- INTEL_THC_HID [=y] && HID_SUPPORT [=y] && X86_64 [=y] && PCI [=y] && ACPI [=y]
WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS
Depends on [m]: INPUT [=m]
Selected by [y]:
- HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y]
- GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y]
- HID_WIIMOTE [=y] && HID_SUPPORT [=y] && HID [=y] && LEDS_CLASS [=y]
- ZEROPLUS_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ZEROPLUS [=y]
Selected by [m]:
- HID_ACRUX_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ACRUX [=m]
- HID_EMS_FF [=m] && HID_SUPPORT [=y] && HID [=y]
- HID_GOOGLE_STADIA_FF [=m] && HID_SUPPORT [=y] && HID [=y]
- PANTHERLORD_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_PANTHERLORD [=m]
It's better to be consistent and always use 'depends on HID' for HID
drivers. The notable exception here is USB_KBD/USB_MOUSE, which are
alternative implementations that do not depend on the HID subsystem.
Do this by extending the "if HID" section below, which means that a few
of the duplicate "depends on HID" and "depends on INPUT" statements
can be removed in the process.
Fixes: 1b2d05384c
("HID: intel-thc-hid: Add basic THC driver skeleton")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Reviewed-by: Even Xu <even.xu@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
85 lines
2.6 KiB
Plaintext
85 lines
2.6 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
menu "USB HID support"
|
|
depends on USB
|
|
|
|
config USB_HID
|
|
tristate "USB HID transport layer"
|
|
default y
|
|
depends on HID
|
|
help
|
|
Say Y here if you want to connect USB keyboards,
|
|
mice, joysticks, graphic tablets, or any other HID based devices
|
|
to your computer via USB, as well as Uninterruptible Power Supply
|
|
(UPS) and monitor control devices.
|
|
|
|
You can't use this driver and the HIDBP (Boot Protocol) keyboard
|
|
and mouse drivers at the same time. More information is available:
|
|
<file:Documentation/input/input.rst>.
|
|
|
|
If unsure, say Y.
|
|
|
|
To compile this driver as a module, choose M here: the
|
|
module will be called usbhid.
|
|
|
|
comment "Input core support is needed for USB HID input layer or HIDBP support"
|
|
depends on USB_HID && INPUT=n
|
|
|
|
config HID_PID
|
|
bool "PID device support"
|
|
help
|
|
Say Y here if you have a PID-compliant device and wish to enable force
|
|
feedback for it. Microsoft Sidewinder Force Feedback 2 is one of such
|
|
devices.
|
|
|
|
config USB_HIDDEV
|
|
bool "/dev/hiddev raw HID device support"
|
|
depends on USB_HID
|
|
help
|
|
Say Y here if you want to support HID devices (from the USB
|
|
specification standpoint) that aren't strictly user interface
|
|
devices, like monitor controls and Uninterruptible Power Supplies.
|
|
|
|
This module supports these devices separately using a separate
|
|
event interface on /dev/usb/hiddevX (char 180:96 to 180:111).
|
|
|
|
If unsure, say Y.
|
|
|
|
menu "USB HID Boot Protocol drivers"
|
|
depends on USB!=n && USB_HID!=y && EXPERT
|
|
|
|
config USB_KBD
|
|
tristate "USB HIDBP Keyboard (simple Boot) support"
|
|
depends on USB && INPUT
|
|
help
|
|
Say Y here only if you are absolutely sure that you don't want
|
|
to use the generic HID driver for your USB keyboard and prefer
|
|
to use the keyboard in its limited Boot Protocol mode instead.
|
|
|
|
This is almost certainly not what you want. This is mostly
|
|
useful for embedded applications or simple keyboards.
|
|
|
|
To compile this driver as a module, choose M here: the
|
|
module will be called usbkbd.
|
|
|
|
If even remotely unsure, say N.
|
|
|
|
config USB_MOUSE
|
|
tristate "USB HIDBP Mouse (simple Boot) support"
|
|
depends on USB && INPUT
|
|
help
|
|
Say Y here only if you are absolutely sure that you don't want
|
|
to use the generic HID driver for your USB mouse and prefer
|
|
to use the mouse in its limited Boot Protocol mode instead.
|
|
|
|
This is almost certainly not what you want. This is mostly
|
|
useful for embedded applications or simple mice.
|
|
|
|
To compile this driver as a module, choose M here: the
|
|
module will be called usbmouse.
|
|
|
|
If even remotely unsure, say N.
|
|
|
|
endmenu
|
|
|
|
endmenu
|