drm/panel: Add new helpers for refcounted panel allocatons

Introduce reference counted allocations for panels to avoid
use-after-free. The patch adds the macro devm_drm_bridge_alloc()
to allocate a new refcounted panel. Followed the documentation for
drmm_encoder_alloc() and devm_drm_dev_alloc and other similar
implementations for this purpose.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
Link: https://lore.kernel.org/r/20250331-b4-panel-refcounting-v4-1-dad50c60c6c9@redhat.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
This commit is contained in:
Anusha Srivatsa 2025-03-31 11:15:25 -04:00 committed by Maxime Ripard
parent 65931bbc51
commit ed9c594d49
No known key found for this signature in database
GPG Key ID: E3EF0D6F671851C5
2 changed files with 47 additions and 0 deletions

View File

@ -355,6 +355,31 @@ struct drm_panel *of_drm_find_panel(const struct device_node *np)
}
EXPORT_SYMBOL(of_drm_find_panel);
void *__devm_drm_panel_alloc(struct device *dev, size_t size, size_t offset,
const struct drm_panel_funcs *funcs,
int connector_type)
{
void *container;
struct drm_panel *panel;
if (!funcs) {
dev_warn(dev, "Missing funcs pointer\n");
return ERR_PTR(-EINVAL);
}
container = devm_kzalloc(dev, size, GFP_KERNEL);
if (!container)
return ERR_PTR(-ENOMEM);
panel = container + offset;
panel->funcs = funcs;
drm_panel_init(panel, dev, funcs, connector_type);
return container;
}
EXPORT_SYMBOL(__devm_drm_panel_alloc);
/**
* of_drm_get_panel_orientation - look up the orientation of the panel through
* the "rotation" binding from a device tree node

View File

@ -268,6 +268,28 @@ struct drm_panel {
bool enabled;
};
void *__devm_drm_panel_alloc(struct device *dev, size_t size, size_t offset,
const struct drm_panel_funcs *funcs,
int connector_type);
/**
* devm_drm_panel_alloc - Allocate and initialize a refcounted panel.
*
* @dev: struct device of the panel device
* @type: the type of the struct which contains struct &drm_panel
* @member: the name of the &drm_panel within @type
* @funcs: callbacks for this panel
* @connector_type: the connector type (DRM_MODE_CONNECTOR_*) corresponding to
* the panel interface
*
* Returns:
* Pointer to container structure embedding the panel, ERR_PTR on failure.
*/
#define devm_drm_panel_alloc(dev, type, member, funcs, connector_type) \
((type *)__devm_drm_panel_alloc(dev, sizeof(type), \
offsetof(type, member), funcs, \
connector_type))
void drm_panel_init(struct drm_panel *panel, struct device *dev,
const struct drm_panel_funcs *funcs,
int connector_type);