mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
synced 2025-09-04 18:49:41 +00:00
bcachefs: Fix bch2_trigger_alloc when upgrading from old versions
bch2_trigger_alloc was assuming that the new key would always be newly created and thus always an alloc_v4 key, but - not when called from btree_gc. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
This commit is contained in:
parent
a24e6e7146
commit
bd864bc2d9
@ -829,7 +829,19 @@ int bch2_trigger_alloc(struct btree_trans *trans,
|
|||||||
|
|
||||||
struct bch_alloc_v4 old_a_convert;
|
struct bch_alloc_v4 old_a_convert;
|
||||||
const struct bch_alloc_v4 *old_a = bch2_alloc_to_v4(old, &old_a_convert);
|
const struct bch_alloc_v4 *old_a = bch2_alloc_to_v4(old, &old_a_convert);
|
||||||
struct bch_alloc_v4 *new_a = bkey_s_to_alloc_v4(new).v;
|
|
||||||
|
struct bch_alloc_v4 *new_a;
|
||||||
|
if (likely(new.k->type == KEY_TYPE_alloc_v4)) {
|
||||||
|
new_a = bkey_s_to_alloc_v4(new).v;
|
||||||
|
} else {
|
||||||
|
BUG_ON(!(flags & BTREE_TRIGGER_gc));
|
||||||
|
|
||||||
|
struct bkey_i_alloc_v4 *new_ka = bch2_alloc_to_v4_mut_inlined(trans, new.s_c);
|
||||||
|
ret = PTR_ERR_OR_ZERO(new_ka);
|
||||||
|
if (unlikely(ret))
|
||||||
|
goto err;
|
||||||
|
new_a = &new_ka->v;
|
||||||
|
}
|
||||||
|
|
||||||
if (flags & BTREE_TRIGGER_transactional) {
|
if (flags & BTREE_TRIGGER_transactional) {
|
||||||
alloc_data_type_set(new_a, new_a->data_type);
|
alloc_data_type_set(new_a, new_a->data_type);
|
||||||
|
Loading…
Reference in New Issue
Block a user