Proxmox-Port/linux-loongson
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson synced 2025-09-08 07:16:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

devlink: make devlink_param_driverinit_value_set() return void

Browse Source 
devlink_param_driverinit_value_set() currently returns int with possible
error, but no user is checking it anyway. The only reason for a fail is
a driver bug. So convert the function to return void and put WARN_ONs
on error paths.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jiri Pirko 2023-01-26 08:58:33 +01:00 committed by David S. Miller
parent 6fd6eda0e6
commit 85fe0b324c
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/net/devlink.h
View File

@ -1775,8 +1775,8 @@ void devlink_params_unregister(struct devlink *devlink,
size_t params_count); size_t params_count);
int devlink_param_driverinit_value_get(struct devlink *devlink, u32 param_id, int devlink_param_driverinit_value_get(struct devlink *devlink, u32 param_id,
union devlink_param_value *init_val); union devlink_param_value *init_val);
int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id, void devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
union devlink_param_value init_val); union devlink_param_value init_val);
void devlink_param_value_changed(struct devlink *devlink, u32 param_id); void devlink_param_value_changed(struct devlink *devlink, u32 param_id);
struct devlink_region *devl_region_create(struct devlink *devlink, struct devlink_region *devl_region_create(struct devlink *devlink,
const struct devlink_region_ops *ops, const struct devlink_region_ops *ops,

15
net/devlink/leftover.c
View File

@ -10931,18 +10931,18 @@ EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_get);
* This function should be used by the driver to set driverinit * This function should be used by the driver to set driverinit
* configuration mode default value. * configuration mode default value.
*/ */
int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id, void devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
union devlink_param_value init_val) union devlink_param_value init_val)
{ {
struct devlink_param_item *param_item; struct devlink_param_item *param_item;
param_item = devlink_param_find_by_id(&devlink->param_list, param_id); param_item = devlink_param_find_by_id(&devlink->param_list, param_id);
if (!param_item) if (WARN_ON(!param_item))
return -EINVAL; return;
if (!devlink_param_cmode_is_supported(param_item->param, if (WARN_ON(!devlink_param_cmode_is_supported(param_item->param,
DEVLINK_PARAM_CMODE_DRIVERINIT)) DEVLINK_PARAM_CMODE_DRIVERINIT)))
return -EOPNOTSUPP; return;
if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING) if (param_item->param->type == DEVLINK_PARAM_TYPE_STRING)
strcpy(param_item->driverinit_value.vstr, init_val.vstr); strcpy(param_item->driverinit_value.vstr, init_val.vstr);
@ -10951,7 +10951,6 @@ int devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id,
param_item->driverinit_value_valid = true; param_item->driverinit_value_valid = true;
devlink_param_notify(devlink, 0, param_item, DEVLINK_CMD_PARAM_NEW); devlink_param_notify(devlink, 0, param_item, DEVLINK_CMD_PARAM_NEW);
return 0;
} }
EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_set); EXPORT_SYMBOL_GPL(devlink_param_driverinit_value_set);