Proxmox-Port/linux-loongson
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson synced 2025-08-30 21:52:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

docs: deprecated.rst: Clarify open-coded arithmetic with literals

Browse Source 
Although using literals for size calculation in allocator arguments may
be harmless due to compiler warnings in case of overflows, it is better
to refactor the code to avoid the use of open-coded arithmetic.

So, clarify the preferred way in these cases.

Suggested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Len Baker <len.baker@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20210925143455.21221-1-len.baker@gmx.com
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
This commit is contained in:
Len Baker 2021-09-25 16:34:55 +02:00 committed by Jonathan Corbet
parent 6e74e68d0b
commit 3577cdb23b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/process/deprecated.rst
View File

@ -59,8 +59,9 @@ risk of them overflowing. This could lead to values wrapping around and a
smaller allocation being made than the caller was expecting. Using those smaller allocation being made than the caller was expecting. Using those
allocations could lead to linear overflows of heap memory and other allocations could lead to linear overflows of heap memory and other
misbehaviors. (One exception to this is literal values where the compiler misbehaviors. (One exception to this is literal values where the compiler
can warn if they might overflow. Though using literals for arguments as can warn if they might overflow. However, the preferred way in these
suggested below is also harmless.) cases is to refactor the code as suggested below to avoid the open-coded
arithmetic.)
For example, do not use ``count * size`` as an argument, as in:: For example, do not use ``count * size`` as an argument, as in::