Proxmox-Port/libtpms
1
0
Fork 0
mirror of https://github.com/stefanberger/libtpms synced 2026-08-08 05:26:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tpm2: Initialize variable reported by Coverity (false positive)

Browse Source 
Initialize a variable in TPM2_PolicyAuthorizeNV() following Coverity
report CID 1470811.

Down the callpath as reported in CID 1470811 in TPMI_ALG_HASH_Unmarshal()
the passed-in value of TPMI_ALG_HASH *target is stored and possibly
restored later on in case of failure. Coverity complains that the variable
is uninitialized. While this is correct, there's no harm reading the
uninitialized value from the structure and possibly restoring it later
on while not doing anything else with it otherwise. Therefore, it's a
false positive.

Resolves: https://github.com/stefanberger/libtpms/issues/311
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This commit is contained in:
Stefan Berger 2022-03-31 10:30:04 -04:00
parent ec873cf8a2
commit fbf413ec86
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/tpm2/EACommands.c
View File

@ -1116,7 +1116,9 @@ TPM2_PolicyAuthorizeNV(
NV_REF locator;
NV_INDEX *nvIndex = NvGetIndexInfo(in->nvIndex, &locator);
TPM2B_NAME name;
TPMT_HA policyInNv;
TPMT_HA policyInNv = {
.hashAlg = 0, // libpms added: Coverity
};
BYTE nvTemp[sizeof(TPMT_HA)];
BYTE *buffer = nvTemp;
INT32 size;