Proxmox-Port/libtpms
1
0
Fork 0
mirror of https://github.com/stefanberger/libtpms synced 2025-12-26 14:24:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tpm2: Add fallthrough comments to avoid static analyzer warnings

Browse Source 
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This commit is contained in:
Stefan Berger 2024-10-03 12:33:11 -04:00 committed by Stefan Berger
parent 648cc1ec78
commit cbd894e281
4 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/tpm2/AlgorithmTests.c
View File

@ -886,6 +886,7 @@ TestAlgorithm(TPM_ALG_ID alg, ALGORITHM_VECTOR* toTest)
case TPM_ALG_SM4: /* libtpms changed */
# endif // ALG_SM4
# if ALG_CAMELLIA
/* fallthrough */
case TPM_ALG_CAMELLIA: // libtpms activated
# endif
# if ALG_TDES

2
src/tpm2/NVCommands.c
View File

@ -154,9 +154,9 @@ TPM2_NV_DefineSpace(
// It is not allowed to create a PIN Index that can't be modified.
if(!IS_ATTRIBUTE(attributes, TPMA_NV, NO_DA))
return TPM_RCS_ATTRIBUTES + RC_NV_DefineSpace_publicInfo;
/* fall through */
#endif
#ifdef TPM_NT_PIN_PASS
/* fallthrough */ // libtpms moved
case TPM_NT_PIN_PASS:
// AUTHWRITE must be CLEAR (see note above to TPM_NT_PIN_FAIL)
if(IS_ATTRIBUTE(attributes, TPMA_NV, AUTHWRITE)

1
src/tpm2/Object_spt.c
View File

@ -427,6 +427,7 @@ CreateChecks(OBJECT* parentObject,
// comment out the next line in order to prevent a fixedTPM derivation
// parent
// break;
/* fallthrough */ // libtpms added
case TPM_ALG_SYMCIPHER:
// A restricted key symmetric key (SYMCIPHER and KEYEDHASH)
// must have sensitiveDataOrigin SET unless it has fixedParent and

16
src/tpm2/Unmarshal.c
View File

@ -905,6 +905,7 @@ TPMI_RH_HIERARCHY_Unmarshal(TPMI_RH_HIERARCHY *target, BYTE **buffer, INT32 *siz
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_VALUE;
*target = orig_target; // libtpms added
@ -935,6 +936,7 @@ TPMI_RH_ENABLES_Unmarshal(TPMI_RH_ENABLES *target, BYTE **buffer, INT32 *size, B
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_VALUE;
*target = orig_target; // libtpms added
@ -1042,6 +1044,7 @@ TPMI_RH_ENDORSEMENT_Unmarshal(TPMI_RH_ENDORSEMENT *target, BYTE **buffer, INT32
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_VALUE;
*target = orig_target; // libtpms added
@ -1339,6 +1342,7 @@ TPMI_ALG_HASH_Unmarshal(TPMI_ALG_HASH *target, BYTE **buffer, INT32 *size, BOOL
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_HASH;
}
@ -1386,6 +1390,7 @@ TPMI_ALG_SYM_Unmarshal(TPMI_ALG_SYM *target, BYTE **buffer, INT32 *size, BOOL al
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_SYMMETRIC;
}
@ -1430,6 +1435,7 @@ TPMI_ALG_SYM_OBJECT_Unmarshal(TPMI_ALG_SYM_OBJECT *target, BYTE **buffer, INT32
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_SYMMETRIC;
}
@ -1480,6 +1486,7 @@ TPMI_ALG_SYM_MODE_Unmarshal(TPMI_ALG_SYM_MODE *target, BYTE **buffer, INT32 *siz
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_MODE;
}
@ -1520,6 +1527,7 @@ TPMI_ALG_KDF_Unmarshal(TPMI_ALG_KDF *target, BYTE **buffer, INT32 *size, BOOL al
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_KDF;
*target = orig_target; // libtpms added
@ -1571,6 +1579,7 @@ TPMI_ALG_SIG_SCHEME_Unmarshal(TPMI_ALG_SIG_SCHEME *target, BYTE **buffer, INT32
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_SCHEME;
}
@ -1612,6 +1621,7 @@ TPMI_ECC_KEY_EXCHANGE_Unmarshal(TPMI_ECC_KEY_EXCHANGE *target, BYTE **buffer, IN
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_SCHEME;
}
@ -1687,6 +1697,7 @@ TPMI_ALG_MAC_SCHEME_Unmarshal(TPMI_ALG_MAC_SCHEME *target, BYTE **buffer, INT32
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_SYMMETRIC;
}
@ -1734,6 +1745,7 @@ TPMI_ALG_CIPHER_MODE_Unmarshal(TPMI_ALG_CIPHER_MODE*target, BYTE **buffer, INT32
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_MODE;
}
@ -3303,6 +3315,7 @@ TPMI_ALG_KEYEDHASH_SCHEME_Unmarshal(TPMI_ALG_KEYEDHASH_SCHEME *target, BYTE **bu
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_VALUE;
*target = orig_target; // libtpms added
@ -3860,6 +3873,7 @@ TPMI_ALG_RSA_SCHEME_Unmarshal(TPMI_ALG_RSA_SCHEME *target, BYTE **buffer, INT32
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_VALUE;
}
@ -3911,6 +3925,7 @@ TPMI_ALG_RSA_DECRYPT_Unmarshal(TPMI_ALG_RSA_DECRYPT *target, BYTE **buffer, INT3
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_VALUE;
*target = orig_target; // libtpms added
@ -4101,6 +4116,7 @@ TPMI_ALG_ECC_SCHEME_Unmarshal(TPMI_ALG_ECC_SCHEME *target, BYTE **buffer, INT32
if (allowNull) {
break;
}
/* fallthrough */
default:
rc = TPM_RC_SCHEME;
}