Proxmox-Port/libtpms
1
0
Fork 0
mirror of https://github.com/stefanberger/libtpms synced 2026-08-07 19:47:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tpm2: Fix bugs in RuntimeProfileDedupStrItems

Browse Source 
Fix the following bugs in RuntimeProfileDedupStrItems:
- RuntimeProfileDedupStrItems did not memmove the correct number of bytes,
  leading to potential crashes.
- Also, it did not handle deduplicating the last item in the comma-
  separated list correctly.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This commit is contained in:
Stefan Berger 2025-05-08 00:47:19 -04:00 committed by Stefan Berger
parent 729b59bceb
commit a643f1e29e
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/tpm2/RuntimeProfile.c
View File

@ -247,9 +247,9 @@ exit:
static void
RuntimeProfileDedupStrItems(char *input)
{
size_t len = strlen(input), slen;
char *comma, *equals, *dup, *ncomma;
char *pos = input;
size_t slen;
bool found;
char exp;
@ -277,13 +277,14 @@ RuntimeProfileDedupStrItems(char *input)
dup = strstr(ncomma + 1, pos);
if (dup) {
/* ensure 'dup' is a prefix of 'pos' with either ',' or '\0' before it */
if ((dup[-1] == ',' || dup[-1] == 0) && dup[slen] == exp) {
memmove(pos, comma + 1, len - slen);
if (((dup[-1] == ',' || dup[-1] == 0) && dup[slen] == exp) ||
(dup[slen] == 0) /* last item in list */) {
memmove(pos, comma + 1, strlen(comma + 1) + 1);
/* keep pos as-is */
found = true;
break;
}
/* only a prefix matched; continue search afer comma */
/* only a prefix matched; continue search after comma */
ncomma = index(dup, ',');
if (!ncomma)
break;
@ -297,7 +298,6 @@ RuntimeProfileDedupStrItems(char *input)
*equals = '=';
pos = comma + 1;
}
len -= (slen + 1);
}
}