Proxmox-Port/libtpms
1
0
Fork 0
mirror of https://github.com/stefanberger/libtpms synced 2026-08-11 19:26:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tpm2: Add a pAssert after a statement causing unfounded Coverity complaint

Browse Source 
This is the Coverity complaint about the line

infoDataSize = TimeGetMarshaled(&infoData);

CID 1402057: Out-of-bounds access (OVERRUN)
1. overrun-buffer-val: Overrunning array infoData of 32 bytes by passing
  it to a function which accesses it at byte offset 255.

TimeGetMarshaled() correctly serializes into &infoData, which is casted to
a buffer and then the data are written into the buffer. Also only 25 bytes,
as indicated by infoDataSize, are used, which is less than sizeof(infoData),
which is 32.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This commit is contained in:
Stefan Berger 2020-04-24 16:46:45 -04:00 committed by Stefan Berger
parent db80bd9ea1
commit 92d1544b0d
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/tpm2/EACommands.c
View File

@ -611,6 +611,7 @@ TPM2_PolicyCounterTimer(
// Input Validation
// Get a marshaled time structure
infoDataSize = TimeGetMarshaled(&infoData);
pAssert(infoDataSize <= sizeof(infoData)); // libtpms added; 25 < 32 ==> unfounded coverity complaint
// Make sure that the referenced stays within the bounds of the structure.
// NOTE: the offset checks are made even for a trial policy because the policy
// will not make any sense if the references are out of bounds of the timer