From 40c909ec77354e11f21cfaaeac09fb3b0cbca93d Mon Sep 17 00:00:00 2001 From: Stefan Berger Date: Mon, 29 Jul 2024 10:19:00 -0400 Subject: [PATCH] tpm2: Return TPM_RC_VALUE upon decryption failure When decryption fails then return TPM_RC_VALUE rather than TPM_RC_FAILURE. The old error code could indicate to an application or driver that something is wrong with the TPM (has possibly gone into failure mode) even though only the decryption failed, possibly due to a wrong key. Signed-off-by: Stefan Berger --- src/tpm2/crypto/openssl/CryptRsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tpm2/crypto/openssl/CryptRsa.c b/src/tpm2/crypto/openssl/CryptRsa.c index 21175cd0..225c3c74 100644 --- a/src/tpm2/crypto/openssl/CryptRsa.c +++ b/src/tpm2/crypto/openssl/CryptRsa.c @@ -1377,7 +1377,7 @@ CryptRsaDecrypt( outlen = sizeof(buffer); if (EVP_PKEY_decrypt(ctx, buffer, &outlen, cIn->buffer, cIn->size) <= 0) - ERROR_RETURN(TPM_RC_FAILURE); + ERROR_RETURN(TPM_RC_VALUE); if (outlen > dOut->size) ERROR_RETURN(TPM_RC_FAILURE);